Bug 189016 – WebKitMediaSession should be GC collectable when its document is being stopped

• Component: WebRTC
• Status: RESOLVED FIXED

[youenn fablet]

MediaDevices and WebKitMediaSession should be GC collectable when their document is being stopped

[youenn fablet]

Created attachment 348220 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 348220 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348220&action=review

> Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.h:44
> +class WebKitMediaKeySession final : public RefCounted<WebKitMediaKeySession>, public EventTargetWithInlineData, public ActiveDOMObject, private LegacyCDMSessionClient {

Why was this change required?

> LayoutTests/http/tests/media/clearkey/collect-webkit-media-session.html:42
> +}, "Ensuring frame document gets collected after being stopped while doing some webkit media session calls");

This reads oddly. Maybe "Ensure that the frame's document get collected after being stopped while doing some webkit media session calls"

[youenn fablet]

Comment on attachment 348220 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348220&action=review

>> Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.h:44
>> +class WebKitMediaKeySession final : public RefCounted<WebKitMediaKeySession>, public EventTargetWithInlineData, public ActiveDOMObject, private LegacyCDMSessionClient {
> 
> Why was this change required?

Needed for bug 189018, but not needed for this one, I'll remove the change here.

[youenn fablet]

Created attachment 348295 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 348295 [details]
Patch

Clearing flags on attachment: 348295

Committed r235429: <https://trac.webkit.org/changeset/235429>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/43804904>

[Truitt Savell]

The new test http/tests/media/clearkey/collect-webkit-media-session.html

is flakey, Test History:
http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fmedia%2Fclearkey%2Fcollect-webkit-media-session.html

Diff:
--- /Volumes/Data/slave/highsierra-leaks/build/layout-test-results/http/tests/media/clearkey/collect-webkit-media-session-expected.txt
+++ /Volumes/Data/slave/highsierra-leaks/build/layout-test-results/http/tests/media/clearkey/collect-webkit-media-session-actual.txt
@@ -1,4 +1,4 @@
 
 
-PASS Ensure that the frame's document get collected after being stopped while doing some webkit media session calls 
+FAIL Ensure that the frame's document get collected after being stopped while doing some webkit media session calls promise_test: Unhandled rejection with value: "Test failed"

[youenn fablet]

Reopening to attach new patch.

[youenn fablet]

Created attachment 348373 [details]
Unflake test

[WebKit Commit Bot]

Comment on attachment 348373 [details]
Unflake test

Clearing flags on attachment: 348373

Committed r235453: <https://trac.webkit.org/changeset/235453>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

(In reply to WebKit Commit Bot from comment #11)
> Comment on attachment 348373 [details]
> Unflake test
> 
> Clearing flags on attachment: 348373
> 
> Committed r235453: <https://trac.webkit.org/changeset/235453>
http/tests/media/clearkey/collect-webkit-media-session.html is still flaky after this change. It fails with the same diff as above.

[youenn fablet]

(In reply to Ryan Haddad from comment #13)
> (In reply to WebKit Commit Bot from comment #11)
> > Comment on attachment 348373 [details]
> > Unflake test
> > 
> > Clearing flags on attachment: 348373
> > 
> > Committed r235453: <https://trac.webkit.org/changeset/235453>
> http/tests/media/clearkey/collect-webkit-media-session.html is still flaky
> after this change. It fails with the same diff as above.

I saw that and tried to reproduce it on my local machine but was not able to reproduce.
I'll try again.