Summary: | Password field has focus but can't type text (i.rememberthemilk.com) | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||||
Component: | Forms | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | adele, aegolden | ||||||||
Priority: | P2 | Keywords: | HasReduction, InRadar | ||||||||
Version: | 523.x (Safari 3) | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.5 | ||||||||||
URL: | http://i.rememberthemilk.com/ | ||||||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2008-05-05 16:18:45 PDT
Created attachment 20985 [details]
possible reduction
(In reply to comment #0) > * REGRESSION > Unknown. Only tested with Safari 3.1.1 on Mac OS X 10.5.x Leopard. This is not a regression. Safari 2.0.4 with original WebKit on Mac OS X 10.4.11 exhibits similar behavior. WebKit nightly build r11976 exhibits the same behavior as ToT WebKit today (r32901). (In reply to comment #1) > Created an attachment (id=20985) [edit] > possible reduction Great reduction, Marcus! Thanks! Created attachment 20991 [details]
Proposed patch, minus new layout test
The patch makes HTMLInputElement handle the edge case where the document is changing the type of the focused node. The node needs to update its selection range after reattaching.
Comment on attachment 20991 [details]
Proposed patch, minus new layout test
instead of setting the selection range directly, it might be better to call updateFocusAppearance with the right value for restorePreviousSelection
Created attachment 21000 [details]
Patch v2
Patch with layout test and changelogs.
All existing layout tests pass with this change.
Committed revision 32959. In the original page, the <input> element that held the password would change from type="text" to type="password" using an onfocus event. This bug is fixed for the original page. The new page uses two <input> tags, and changes their CSS class to make then hidden or visible. It works with mouse clicks, but fails with tabs. This seems to be a server-side issue that it doesn't do the same thing with tabbed focus as with mouse clicks. |