Bug 188987

Summary:

Convert timeout values in WebKitTestRunner to WTF::Seconds

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, ews-watchlist, rniwa, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	rniwa: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none

Simon Fraser (smfr)

Reported 2018-08-27 10:31:03 PDT

Convert timeout values in WebKitTestRunner to WTF::Seconds

Attachments
Patch (22.27 KB, patch) 2018-08-27 10:34 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (22.29 KB, patch) 2018-08-27 10:52 PDT, Simon Fraser (smfr)	rniwa: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (771.53 KB, application/zip) 2018-08-27 12:06 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (1.42 MB, application/zip) 2018-08-27 12:09 PDT, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2018-08-27 10:34:52 PDT

Created attachment 348158 [details] Patch

Simon Fraser (smfr)

Comment 2 2018-08-27 10:52:07 PDT

Created attachment 348164 [details] Patch

Ryosuke Niwa

Comment 3 2018-08-27 10:53:25 PDT

Comment on attachment 348164 [details] Patch r=ms assuming EWS says it's good.

EWS Watchlist

Comment 4 2018-08-27 12:06:34 PDT

Comment on attachment 348164 [details] Patch Attachment 348164 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8997685 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 5 2018-08-27 12:06:36 PDT

Created attachment 348181 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

EWS Watchlist

Comment 6 2018-08-27 12:09:05 PDT

Comment on attachment 348164 [details] Patch Attachment 348164 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8998186 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 7 2018-08-27 12:09:07 PDT

Created attachment 348183 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Simon Fraser (smfr)

Comment 8 2018-08-27 14:16:33 PDT

https://trac.webkit.org/r235399

Radar WebKit Bug Importer

Comment 9 2018-08-27 14:18:14 PDT

<rdar://problem/43769169>

Note You need to log in before you can comment on or make changes to this bug.