Bug 188985

Summary: [Payment Request] Update payment-request web platform tests
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aestes, andersca, commit-queue, rniwa, sam, thorton, tsavell, webkit-bug-importer, wenson_hsieh, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andy Estes
Reported 2018-08-27 10:02:08 PDT
[Payment Request] Update payment-request web platform tests
Attachments
Patch (53.83 KB, patch)
2018-08-27 10:04 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (157.64 KB, patch)
2018-08-27 10:27 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2018-08-27 10:04:17 PDT Comment hidden (obsolete)
Andy Estes
Comment 2 2018-08-27 10:27:43 PDT
Created attachment 348157 [details] Patch
youenn fablet
Comment 3 2018-08-27 11:42:21 PDT
Comment on attachment 348157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348157&action=review > LayoutTests/imported/w3c/web-platform-tests/payment-request/idlharness.https.window-expected.txt:1 > +CONSOLE MESSAGE: line 8: ReferenceError: Can't find variable: idl_test Are we missing some other imports in common or resources?
Andy Estes
Comment 4 2018-08-27 11:59:28 PDT
(In reply to youenn fablet from comment #3) > Comment on attachment 348157 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=348157&action=review > > > LayoutTests/imported/w3c/web-platform-tests/payment-request/idlharness.https.window-expected.txt:1 > > +CONSOLE MESSAGE: line 8: ReferenceError: Can't find variable: idl_test > > Are we missing some other imports in common or resources? Good question. I'll check!
WebKit Commit Bot
Comment 5 2018-08-27 12:30:42 PDT
Comment on attachment 348157 [details] Patch Clearing flags on attachment: 348157 Committed r235390: <https://trac.webkit.org/changeset/235390>
WebKit Commit Bot
Comment 6 2018-08-27 12:30:44 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-08-27 12:33:29 PDT
<rdar://problem/43764668>
Truitt Savell
Comment 8 2018-08-28 14:31:48 PDT
Moved test expectations from mac-wk2 to general in: https://trac.webkit.org/changeset/235441/webkit This should stop the failures across iOS.
Note You need to log in before you can comment on or make changes to this bug.