Bug 188981

Summary: Fix gcc compilation warnings after r235230
Product: WebKit Reporter: Alejandro G. Castro <alex>
Component: WebRTCAssignee: Alejandro G. Castro <alex>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alejandro G. Castro
Reported 2018-08-27 04:02:40 PDT
We are using pragma clang to avoid unused-parameter warnings in the libwebrtc directories, gcc does not understand this pragmas.
Attachments
Patch (9.60 KB, patch)
2018-08-27 04:09 PDT, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alejandro G. Castro
Comment 1 2018-08-27 04:09:17 PDT
Created attachment 348130 [details] Patch
WebKit Commit Bot
Comment 2 2018-08-28 00:49:22 PDT
Comment on attachment 348130 [details] Patch Clearing flags on attachment: 348130 Committed r235421: <https://trac.webkit.org/changeset/235421>
WebKit Commit Bot
Comment 3 2018-08-28 00:49:24 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-08-28 00:50:48 PDT
<rdar://problem/43788293>
Note You need to log in before you can comment on or make changes to this bug.