Bug 188931

Summary:

Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER

Product:

WebKit

Reporter:

Aditya Keerthi <pxlcoder>

Component:

Forms

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Aditya Keerthi 2018-08-24 14:13:45 PDT

A popover is the preferred interface for <input type=color> on macOS. We can consolidate the two build flags, so that a popover is always displayed in the ENABLE(INPUT_TYPE_COLOR) build.

Comment 1 Aditya Keerthi 2018-08-24 14:58:12 PDT

Created attachment 348042 [details]
Patch

Comment 2 WebKit Commit Bot 2018-08-27 14:48:21 PDT

Comment on attachment 348042 [details]
Patch

Clearing flags on attachment: 348042

Committed r235403: <https://trac.webkit.org/changeset/235403>

Comment 3 WebKit Commit Bot 2018-08-27 14:48:23 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Radar WebKit Bug Importer 2018-08-27 14:49:18 PDT

<rdar://problem/43771114>