Bug 188931

Summary: Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
Product: WebKit Reporter: Aditya Keerthi <pxlcoder>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Aditya Keerthi
Reported 2018-08-24 14:13:45 PDT
A popover is the preferred interface for <input type=color> on macOS. We can consolidate the two build flags, so that a popover is always displayed in the ENABLE(INPUT_TYPE_COLOR) build.
Attachments
Patch (55.26 KB, patch)
2018-08-24 14:58 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2018-08-24 14:58:12 PDT
Created attachment 348042 [details] Patch
WebKit Commit Bot
Comment 2 2018-08-27 14:48:21 PDT
Comment on attachment 348042 [details] Patch Clearing flags on attachment: 348042 Committed r235403: <https://trac.webkit.org/changeset/235403>
WebKit Commit Bot
Comment 3 2018-08-27 14:48:23 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-08-27 14:49:18 PDT
<rdar://problem/43771114>
Note You need to log in before you can comment on or make changes to this bug.