Bug 188929 – Avoid calling setUntrusted in SimulatedMouseEvent

• Component: UI Events
• Status: RESOLVED FIXED

[Ryosuke Niwa]

Pass IsTrusted flag around to superclass' constructors instead.

[Ryosuke Niwa]

Created attachment 348038 [details]
Cleanup

[EWS Watchlist]

Attachment 348038 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/MouseEvent.cpp:84:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/MouseEvent.cpp:84:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/Event.h:146:  The parameter name "isTrusted" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:39:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:39:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/WheelEvent.cpp:51:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/UIEventWithKeyState.h:59:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 7 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 348038 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=348038&action=review

> Source/WebCore/ChangeLog:11
> +        This makes EventTarget::dispatchEventForBindings the only caller of setUntrusted().

Can some of these Event members variables be const variables after these changes?

> Source/WebCore/dom/Event.h:146
> +    Event(const AtomicString& type, CanBubble, IsCancelable, IsComposed, MonotonicTime timestamp, IsTrusted isTrusted = IsTrusted::Yes);

You don't need to name the parameter here.

[EWS Watchlist]

Comment on attachment 348038 [details]
Cleanup

Attachment 348038 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8975203

New failing tests:
imported/w3c/web-platform-tests/shadow-dom/event-composed.html

[EWS Watchlist]

Created attachment 348043 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 348038 [details]
Cleanup

Attachment 348038 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8975217

New failing tests:
imported/w3c/web-platform-tests/shadow-dom/event-composed.html

[EWS Watchlist]

Created attachment 348045 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Ryosuke Niwa]

Comment on attachment 348038 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=348038&action=review

> Source/WebCore/dom/SimulatedClick.cpp:47
> -        : MouseEvent(eventType, CanBubble::Yes, IsCancelable::Yes, source == SimulatedClickSource::Bindings ? IsComposed::No : IsComposed::Yes,
> +        : MouseEvent(eventType, CanBubble::Yes, IsCancelable::Yes, IsComposed::Yes,

Oh oops, this is the unrelated change causing the test to fail.

[Ryosuke Niwa]

Created attachment 348046 [details]
Patch for landing

[Radar WebKit Bug Importer]

<rdar://problem/43699414>

[EWS Watchlist]

Attachment 348046 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/MouseEvent.cpp:84:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/MouseEvent.cpp:84:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/Event.h:146:  The parameter name "isTrusted" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:39:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:39:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/WheelEvent.cpp:51:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/dom/UIEventWithKeyState.h:59:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 7 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 348046 [details]
Patch for landing

Clearing flags on attachment: 348046

Committed r235335: <https://trac.webkit.org/changeset/235335>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Lucas Forschler]

Mass move bugs into the DOM component.