Bug 188866

Summary: [MediaStream] Store video preset sizes in a map
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
youennf: review+
Patch for landing
none
Patch for landing none

Eric Carlson
Reported 2018-08-22 14:51:54 PDT
Make a map of the available video presets once instead of looking each one up again and again.
Attachments
Patch (13.19 KB, patch)
2018-08-22 15:35 PDT, Eric Carlson 		youennf: review+
DetailsFormatted DiffDiff
Patch for landing (11.56 KB, patch)
2018-08-22 16:31 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.58 KB, patch)
2018-08-23 09:19 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-08-22 15:13:25 PDT
<rdar://problem/43622643>
Eric Carlson
Comment 2 2018-08-22 15:35:49 PDT
Created attachment 347855 [details] Patch
youenn fablet
Comment 3 2018-08-22 16:00:38 PDT
Comment on attachment 347855 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347855&action=review > Source/WebCore/platform/mediastream/RealtimeMediaSource.h:279 > + VideoPresetMap m_supportedPresets; I would keep m_supportedPresets in AVVideoCaptureSource for now since this is the sole user.
Eric Carlson
Comment 4 2018-08-22 16:31:58 PDT
Created attachment 347872 [details] Patch for landing
Eric Carlson
Comment 5 2018-08-23 09:19:51 PDT
Created attachment 347927 [details] Patch for landing
WebKit Commit Bot
Comment 6 2018-08-23 12:31:36 PDT
Comment on attachment 347927 [details] Patch for landing Clearing flags on attachment: 347927 Committed r235233: <https://trac.webkit.org/changeset/235233>
Note You need to log in before you can comment on or make changes to this bug.