Bug 188850

Summary: [CoordGraphics] Drop old-school PlatformLayer management in CoordinatedGraphicsLayer
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, cmarcelo, ews-watchlist, kondapallykalyan, luiz, magomez, mcatanzaro, noam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 187385    
Attachments:
Description Flags
Patch
none
Patch for landing none

Zan Dobersek
Reported 2018-08-22 09:11:26 PDT
[CoordGraphics] Drop old-school PlatformLayer management in CoordinatedGraphicsLayer
Attachments
Patch (8.86 KB, patch)
2018-08-22 09:18 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.78 KB, patch)
2018-08-22 23:29 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-08-22 09:18:17 PDT
Created attachment 347804 [details] Patch
EWS Watchlist
Comment 2 2018-08-22 09:20:43 PDT
Attachment 347804 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:113: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zan Dobersek
Comment 3 2018-08-22 23:29:15 PDT
Created attachment 347908 [details] Patch for landing
Zan Dobersek
Comment 4 2018-08-22 23:30:09 PDT
Comment on attachment 347908 [details] Patch for landing Clearing flags on attachment: 347908 Committed r235219: <https://trac.webkit.org/changeset/235219>
Zan Dobersek
Comment 5 2018-08-22 23:30:12 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-08-22 23:31:28 PDT
<rdar://problem/43633894>
Note You need to log in before you can comment on or make changes to this bug.