Summary: | [CoordGraphics] Revalidate need for 'coordinated update completion' in ThreadedCompositor | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
Component: | New Bugs | Assignee: | Miguel Gomez <magomez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, magomez, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=188693 | ||||||
Attachments: |
|
Description
Zan Dobersek
2018-08-22 04:58:45 PDT
I've been testing the rendering on wkgtk and wpe and seeing whether this "coordinated update completion" was required. In a general case, this path is followed only when the WebGL layer is created. After that, during WebGL rendering, there aren't platform layer updates (new buffers come through the proxy) so there's no such coordination really happening. I've run several WebGL tests, both with wkgtk and wpe and the WebGL rendering is not affected if this change is removed, so I'll send a patch to do so and simplify the code. Created attachment 364532 [details]
Patch
Comment on attachment 364532 [details] Patch Clearing flags on attachment: 364532 Committed r243865: <https://trac.webkit.org/changeset/243865> All reviewed patches have been landed. Closing bug. |