Bug 188837

Summary: Use OptionSet for NetworkCache::Storage::TraverseFlags
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, beidson, commit-queue, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch none

Antti Koivisto
Reported 2018-08-22 04:47:55 PDT
Fewer bit masks.
Attachments
patch (7.62 KB, patch)
2018-08-22 04:52 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (7.62 KB, patch)
2018-08-22 05:03 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (7.62 KB, patch)
2018-08-22 05:52 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2018-08-22 04:52:08 PDT
Created attachment 347777 [details] patch
EWS Watchlist
Comment 2 2018-08-22 04:54:20 PDT
Attachment 347777 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:101: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 3 2018-08-22 05:03:14 PDT
Created attachment 347780 [details] patch
EWS Watchlist
Comment 4 2018-08-22 05:06:00 PDT
Attachment 347780 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:101: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 5 2018-08-22 05:52:01 PDT
Created attachment 347783 [details] patch
EWS Watchlist
Comment 6 2018-08-22 05:55:04 PDT
Attachment 347783 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:101: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 7 2018-08-22 07:19:56 PDT
Comment on attachment 347783 [details] patch Clearing flags on attachment: 347783 Committed r235169: <https://trac.webkit.org/changeset/235169>
WebKit Commit Bot
Comment 8 2018-08-22 07:19:57 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-08-22 07:20:18 PDT
<rdar://problem/43604566>
Note You need to log in before you can comment on or make changes to this bug.