Bug 188837

Summary: Use OptionSet for NetworkCache::Storage::TraverseFlags
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, beidson, commit-queue, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch none

Description Antti Koivisto 2018-08-22 04:47:55 PDT
Fewer bit masks.
Comment 1 Antti Koivisto 2018-08-22 04:52:08 PDT
Created attachment 347777 [details]
patch
Comment 2 EWS Watchlist 2018-08-22 04:54:20 PDT
Attachment 347777 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:101:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2018-08-22 05:03:14 PDT
Created attachment 347780 [details]
patch
Comment 4 EWS Watchlist 2018-08-22 05:06:00 PDT
Attachment 347780 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:101:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Antti Koivisto 2018-08-22 05:52:01 PDT
Created attachment 347783 [details]
patch
Comment 6 EWS Watchlist 2018-08-22 05:55:04 PDT
Attachment 347783 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:101:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Commit Bot 2018-08-22 07:19:56 PDT
Comment on attachment 347783 [details]
patch

Clearing flags on attachment: 347783

Committed r235169: <https://trac.webkit.org/changeset/235169>
Comment 8 WebKit Commit Bot 2018-08-22 07:19:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-08-22 07:20:18 PDT
<rdar://problem/43604566>