Summary: | AudioNode.connect does not return destination node | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | jakubfiala <j4kub.fiala> | ||||
Component: | Web Audio | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Minor | CC: | commit-queue, darin, eric.carlson, jer.noble, webkit-bug-importer, wjahenderson | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Safari 11 | ||||||
Hardware: | All | ||||||
OS: | iOS 11 | ||||||
Attachments: |
|
Description
jakubfiala
2018-08-22 03:36:39 PDT
I started work on a patch for this. Created attachment 351198 [details]
Patch
Comment on attachment 351198 [details]
Patch
Thank you!
Comment on attachment 351198 [details] Patch Clearing flags on attachment: 351198 Committed r236648: <https://trac.webkit.org/changeset/236648> All reviewed patches have been landed. Closing bug. Comment on attachment 351198 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351198&action=review > Source/WebCore/Modules/webaudio/AudioNode.idl:37 > - [MayThrowException] void connect(AudioNode destination, optional unsigned long output = 0, optional unsigned long input = 0); > + [MayThrowException] AudioNode connect(AudioNode destination, optional unsigned long output = 0, optional unsigned long input = 0); I believe there is a slightly more efficient way to do this by using the [ReturnValue] attribute on the destination object, so the JavaScript binding will reuse the passed-in wrapper rather than having to look it up. Comment on attachment 351198 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351198&action=review >> Source/WebCore/Modules/webaudio/AudioNode.idl:37 >> + [MayThrowException] AudioNode connect(AudioNode destination, optional unsigned long output = 0, optional unsigned long input = 0); > > I believe there is a slightly more efficient way to do this by using the [ReturnValue] attribute on the destination object, so the JavaScript binding will reuse the passed-in wrapper rather than having to look it up. Gotcha, should I put together a new patch for that? If so, should the patch be attached to a new bug? (In reply to Walker Henderson from comment #8) > Comment on attachment 351198 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=351198&action=review > > >> Source/WebCore/Modules/webaudio/AudioNode.idl:37 > >> + [MayThrowException] AudioNode connect(AudioNode destination, optional unsigned long output = 0, optional unsigned long input = 0); > > > > I believe there is a slightly more efficient way to do this by using the [ReturnValue] attribute on the destination object, so the JavaScript binding will reuse the passed-in wrapper rather than having to look it up. > > Gotcha, should I put together a new patch for that? If so, should the patch > be attached to a new bug? Why don't you file a new bug and reference this. I threw together a patch for this already. Filed bug 190231. |