Bug 188824

Summary: Web Inspector: Address some ESLint warnings
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix mattbaker: review+

Joseph Pecoraro
Reported 2018-08-21 15:40:54 PDT
Address some ESLint warnings A few were real logic mistakes.
Attachments
[PATCH] Proposed Fix (26.14 KB, patch)
2018-08-21 15:41 PDT, Joseph Pecoraro 		mattbaker: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2018-08-21 15:41:46 PDT
Created attachment 347715 [details] [PATCH] Proposed Fix
Matt Baker
Comment 2 2018-08-21 15:55:28 PDT
Comment on attachment 347715 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=347715&action=review r=me > Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js:39 > + if (!(newTestSuite instanceof WI.AuditTestSuite)) Yikes
Joseph Pecoraro
Comment 3 2018-09-10 16:47:59 PDT
<https://trac.webkit.org/changeset/235873/webkit>
Radar WebKit Bug Importer
Comment 4 2018-09-10 16:48:47 PDT
<rdar://problem/44322766>
Note You need to log in before you can comment on or make changes to this bug.