Bug 188785

Summary: Allow creating WeakPtrs to const objects
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, realdawei, sam, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
patch none

Antti Koivisto
Reported 2018-08-21 05:03:47 PDT
const Foo foo; auto weakFoo = makeWeakPtr(foo); should work.
Attachments
patch (10.26 KB, patch)
2018-08-21 06:16 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (10.49 KB, patch)
2018-08-24 00:49 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (10.48 KB, patch)
2018-08-24 01:25 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2018-08-21 06:16:30 PDT
Created attachment 347638 [details] patch
Geoffrey Garen
Comment 2 2018-08-21 09:59:33 PDT
Comment on attachment 347638 [details] patch r=me
WebKit Commit Bot
Comment 3 2018-08-21 12:09:37 PDT
Comment on attachment 347638 [details] patch Clearing flags on attachment: 347638 Committed r235129: <https://trac.webkit.org/changeset/235129>
WebKit Commit Bot
Comment 4 2018-08-21 12:09:38 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-08-21 12:10:24 PDT
<rdar://problem/43571796>
Dawei Fenton (:realdawei)
Comment 6 2018-08-23 16:36:14 PDT
Reverted r235129 for reason: broke internal builds Committed r235258: <https://trac.webkit.org/changeset/235258>
Antti Koivisto
Comment 7 2018-08-24 00:49:39 PDT
Created attachment 347996 [details] patch
Antti Koivisto
Comment 8 2018-08-24 01:25:53 PDT
Created attachment 347999 [details] patch
WebKit Commit Bot
Comment 9 2018-08-24 02:30:59 PDT
Comment on attachment 347999 [details] patch Clearing flags on attachment: 347999 Committed r235315: <https://trac.webkit.org/changeset/235315>
WebKit Commit Bot
Comment 10 2018-08-24 02:31:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.