Bug 188756

Summary: Remove experimental affiliated domain code now that StorageAccess API is available
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, cdumez, dbates, ews-watchlist, japhet, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 174661    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch achristensen: review+

Description Brent Fulgham 2018-08-20 13:37:27 PDT 
In Bug 174661 we added a compatibility quirk to support wsj.com authentication. This quirk is no longer needed, since the StorageAccess API provides the necessary tools to do this type of interaction without needing global cross-site access.
Comment 1 Brent Fulgham 2018-08-20 14:30:56 PDT 
<rdar://problem/43527848>
Comment 2 Brent Fulgham 2018-08-20 14:33:59 PDT 
Created attachment 347546 [details]
Patch
Comment 3 Brent Fulgham 2018-08-20 17:11:46 PDT 
Created attachment 347576 [details]
Patch
Comment 4 Brent Fulgham 2018-08-21 09:28:51 PDT 
Created attachment 347648 [details]
Patch
Comment 5 John Wilander 2018-08-21 10:26:05 PDT 
Mac debug test failures are unrelated.
Comment 6 Brent Fulgham 2018-08-21 10:26:43 PDT 
Despite Alex's r+, I think I made a mistake. I'll upload a revised version.
Comment 7 John Wilander 2018-08-21 10:28:45 PDT 
You probably want to merge with the queued patch from https://bugs.webkit.org/show_bug.cgi?id=188757 or rebase when it's landed.
Comment 8 Brent Fulgham 2018-08-21 10:45:24 PDT 
Created attachment 347659 [details]
Patch
Comment 9 Brent Fulgham 2018-08-21 11:40:54 PDT 
Created attachment 347664 [details]
Patch
Comment 10 Brent Fulgham 2018-08-21 11:41:33 PDT 
Revised patch merged with current ToT uploaded. Ready for a new review!
Comment 11 John Wilander 2018-08-21 13:10:57 PDT 
Comment on attachment 347664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347664&action=review

Looks good to me.

> Source/WebCore/loader/ResourceLoadObserver.cpp:150
> +

Ah, this is a fix of the comparison that was lost when I removed the call to areDomainsAssociated(). Good catch.

> Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.cpp:611
> +

I see, you moved the previous check in WebResourceLoadStatisticsStore's areDomainsAssociated() into here.
Comment 12 Brent Fulgham 2018-08-21 13:37:34 PDT 
Committed r235132: <https://trac.webkit.org/changeset/235132>