Bug 188755

Summary: sort-Xcode-project-file: top-level files and folders are sorted unintentionally when `mainGroup` has no name
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, commit-queue, dbates, ews-watchlist, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 10   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=188754
Bug Depends on: 22555    
Bug Blocks:    
Attachments:
Description Flags
Patch v1
none
Archive of layout-test-results from ews206 for win-future none

David Kilzer (:ddkilzer)
Reported 2018-08-20 12:24:20 PDT
While working on Bug 188754, I noticed that some project files don't have a name for their `mainGroup` group, such as bmalloc and WTF. This is controlled by the `productName` value in the main group, and if it's not set, then there is no name. The sort-Xcode-project-file currently doesn't parse the `mainGroup` unique identifier correctly in this case, so it can sort the main group list (the top level of files and folders in an Xcode project) when it's not supposed to sort them (see Bug 22555).
Attachments
Patch v1 (1.48 KB, patch)
2018-08-20 12:29 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews206 for win-future (12.97 MB, application/zip)
2018-08-20 18:41 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2018-08-20 12:29:36 PDT
Created attachment 347528 [details] Patch v1
EWS Watchlist
Comment 2 2018-08-20 18:40:52 PDT
Comment on attachment 347528 [details] Patch v1 Attachment 347528 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8924051 New failing tests: http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
EWS Watchlist
Comment 3 2018-08-20 18:41:04 PDT
Created attachment 347592 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
WebKit Commit Bot
Comment 4 2018-08-21 14:08:30 PDT
Comment on attachment 347528 [details] Patch v1 Clearing flags on attachment: 347528 Committed r235136: <https://trac.webkit.org/changeset/235136>
WebKit Commit Bot
Comment 5 2018-08-21 14:08:31 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-08-21 14:09:35 PDT
<rdar://problem/43576455>
Note You need to log in before you can comment on or make changes to this bug.