Bug 188733

Summary: [Cocoa] Consolidate inline "wrapper" functions in WebKit API into function templates and WrapperTraits
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit2Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, ews-watchlist, mitz, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
sam: review+, darin: commit-queue+
Archive of layout-test-results from ews206 for win-future none

Description Darin Adler 2018-08-19 12:27:51 PDT
[Cocoa] Consolidate inline "wrapper" functions in WebKit API into function templates and WrapperTraits
Comment 1 Darin Adler 2018-08-19 12:29:06 PDT
Sam, this is the first step of what we talked about in your office the other day.
Comment 2 Darin Adler 2018-08-19 12:42:11 PDT
Created attachment 347462 [details]
Patch
Comment 3 EWS Watchlist 2018-08-19 14:55:08 PDT
Comment on attachment 347462 [details]
Patch

Attachment 347462 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8911228

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
Comment 4 EWS Watchlist 2018-08-19 14:55:20 PDT
Created attachment 347467 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Sam Weinig 2018-08-19 15:12:14 PDT
Comment on attachment 347462 [details]
Patch

Very nice!
Comment 6 Darin Adler 2018-08-19 15:54:35 PDT
Committed r235019: <https://trac.webkit.org/changeset/235019>
Comment 7 Radar WebKit Bug Importer 2018-08-20 16:52:25 PDT
<rdar://problem/43534460>