Bug 188733

Summary: [Cocoa] Consolidate inline "wrapper" functions in WebKit API into function templates and WrapperTraits
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit2Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, ews-watchlist, mitz, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
sam: review+, darin: commit-queue+
Archive of layout-test-results from ews206 for win-future none

Darin Adler
Reported 2018-08-19 12:27:51 PDT
[Cocoa] Consolidate inline "wrapper" functions in WebKit API into function templates and WrapperTraits
Attachments
Patch (62.55 KB, patch)
2018-08-19 12:42 PDT, Darin Adler 		sam: review+
darin: commit-queue+
DetailsFormatted DiffDiff
Archive of layout-test-results from ews206 for win-future (12.89 MB, application/zip)
2018-08-19 14:55 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2018-08-19 12:29:06 PDT
Sam, this is the first step of what we talked about in your office the other day.
Darin Adler
Comment 2 2018-08-19 12:42:11 PDT
Created attachment 347462 [details] Patch
EWS Watchlist
Comment 3 2018-08-19 14:55:08 PDT
Comment on attachment 347462 [details] Patch Attachment 347462 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8911228 New failing tests: http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
EWS Watchlist
Comment 4 2018-08-19 14:55:20 PDT
Created attachment 347467 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Sam Weinig
Comment 5 2018-08-19 15:12:14 PDT
Comment on attachment 347462 [details] Patch Very nice!
Darin Adler
Comment 6 2018-08-19 15:54:35 PDT
Committed r235019: <https://trac.webkit.org/changeset/235019>
Radar WebKit Bug Importer
Comment 7 2018-08-20 16:52:25 PDT
<rdar://problem/43534460>
Note You need to log in before you can comment on or make changes to this bug.