Bug 188725

Summary:

REGRESSION (r234396): Leak of CFURLRef in WebKit::NetworkProcess::deleteHSTSCacheForHostNames()

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

WebKit2

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ggaren, joepeck, mitz, sihui_liu, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

187379

Bug Blocks:

Attachments:

Description	Flags
Patch v1	none

Description David Kilzer (:ddkilzer) 2018-08-18 16:48:03 PDT

Leak of CFURLRef in WebKit::NetworkProcess::deleteHSTSCacheForHostNames():

void NetworkProcess::deleteHSTSCacheForHostNames(WebCore::NetworkStorageSession& session, const Vector<String>& hostNames)
{
    for (auto& hostName : hostNames)
        _CFNetworkResetHSTS(CFURLCreateWithString(kCFAllocatorDefault, hostName.createCFString().get(), NULL), session.platformSession());
}

Found by internal static analyzer bot.

Comment 1 Radar WebKit Bug Importer 2018-08-18 16:48:18 PDT

<rdar://problem/43469670>

Comment 2 David Kilzer (:ddkilzer) 2018-08-18 16:50:46 PDT

Created attachment 347453 [details]
Patch v1

Comment 3 WebKit Commit Bot 2018-08-19 08:16:56 PDT

Comment on attachment 347453 [details]
Patch v1

Clearing flags on attachment: 347453

Committed r235016: <https://trac.webkit.org/changeset/235016>

Comment 4 WebKit Commit Bot 2018-08-19 08:16:57 PDT

All reviewed patches have been landed.  Closing bug.