Bug 188692

Summary: Replace canBubble and cancelable booleans in Event by enum classes
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: UI EventsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, darin, dbates, ews-watchlist, ggaren, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 188720    
Attachments:
Description Flags
Cleanup
none
GTK build fix attempt achristensen: review+

Ryosuke Niwa
Reported 2018-08-16 22:34:39 PDT
Event::Event and Event::create take two booleans to indicate whether an event can bubble and whether it's cancelable. Replace these booleans by enum classes to make the call sites more readable than Event::create(~, false, false).
Attachments
Cleanup (189.35 KB, patch)
2018-08-16 22:40 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
GTK build fix attempt (190.80 KB, patch)
2018-08-16 23:11 PDT, Ryosuke Niwa 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-08-16 22:40:54 PDT
Created attachment 347351 [details] Cleanup
EWS Watchlist
Comment 2 2018-08-16 22:44:11 PDT
Attachment 347351 [details] did not pass style-queue: ERROR: Source/WebCore/dom/KeyboardEvent.cpp:97: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:98: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] Total errors found: 2 in 164 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 3 2018-08-16 23:11:24 PDT
Created attachment 347352 [details] GTK build fix attempt
EWS Watchlist
Comment 4 2018-08-16 23:14:50 PDT
Attachment 347352 [details] did not pass style-queue: ERROR: Source/WebCore/dom/KeyboardEvent.cpp:97: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:98: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/TouchEvent.cpp:42: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/TouchEvent.cpp:44: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] Total errors found: 7 in 165 files If any of these errors are false positives, please file a bug against check-webkit-style.
Radar WebKit Bug Importer
Comment 5 2018-08-16 23:36:07 PDT
<rdar://problem/43411944>
Ryosuke Niwa
Comment 6 2018-08-17 14:24:43 PDT
Committed r234995: <https://trac.webkit.org/changeset/234995>
Ryosuke Niwa
Comment 7 2018-08-17 17:00:27 PDT
Committed r234999: <https://trac.webkit.org/changeset/234999>
Note You need to log in before you can comment on or make changes to this bug.