| Summary: | [GStreamer] Warn early about incomplete MSE track switching support | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
| Component: | Platform | Assignee: | Philippe Normand <pnormand> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aboya, calvaris, ews-watchlist, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Philippe Normand
2018-08-16 08:16:24 PDT
Created attachment 347264 [details]
Patch
Comment on attachment 347264 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347264&action=review Let's also wait for Enrique or Alicia to comment on this before landing. > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:723 > + // FIXME: Remove isMediaSource() test below when fixing https://bugs.webkit.org/show_bug.cgi?id=182531 Nit: . at the end. Comment on attachment 347264 [details] Patch Attachment 347264 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8893622 New failing tests: http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html http/tests/security/video-poster-cross-origin-crash2.html Created attachment 347383 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
This is not something I've tested, but if you have tested that both MP4 and WebM keep working it should be fine. In particular I'm worried of enableTrack() being called in cases without track switching, please confirm that's not the case. (In reply to Alicia Boya García from comment #5) > This is not something I've tested, but if you have tested that both MP4 and > WebM keep working it should be fine. > > In particular I'm worried of enableTrack() being called in cases without > track switching, please confirm that's not the case. This method in the end sets properties on either the pipeline or the source element and even before this patch, nothing was set, only warnings are emitted. Committed r235112: <https://trac.webkit.org/changeset/235112> |