Bug 18865
| Summary: | SquirrelFish: Potential perf issue in Array.join/toString and similar | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ggaren, mjs, oliver, zwarich |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Oliver Hunt
Due to the way we handle toString and valueOf when Array.toString()/join() (and other similar native toString impls) we will repeatedly push and pop registerfiles for each native toString call even though it's not necessary (say in the case of calling join() or an explicit call to Array.toString() )
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Oliver Hunt
This was fixed by the switch to the unified registerfile