Summary: | [win-ews] No such file or directory: u'/cygdrive/C/cygwin/home/buildbot/WebKit/WebKitBuild/Release/bin32/layout-test-results/pywebsocket.ws.log-out.txt' | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
Component: | Tools / Tests | Assignee: | Fujii Hironori <Hironori.Fujii> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | achristensen, ap, ashvayka, commit-queue, ews-watchlist, glenn, Hironori.Fujii, lforschler, pvollan, rniwa, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | Other | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=190236 | ||
Attachments: |
Description
Ryan Haddad
2018-08-15 22:57:06 PDT
This persists after a reboot. Temporarily skip websocket tests in <https://trac.webkit.org/changeset/234933/webkit>. Created attachment 371206 [details]
Patch
I've got the same error when launched `run-webkit-tests` in freshly cloned repository. Pretty sure that busy port is not the cause of this particular problem. I am running macOS 10.14.4, Xcode 10.2.1, webkit-gtk 2.4.11_2, cmake 3.14.4. === STACK TRACE === Failed to remove stale pywebsocket log files: [Errno 2] No such file or directory: '/Users/admin/WebKit/WebKitBuild/Release/layout-test-results' IOError raised: [Errno 2] No such file or directory: u'/Users/admin/WebKit/WebKitBuild/Release/layout-test-results/pywebsocket.ws.log-out.txt' Traceback (most recent call last): File "/Users/admin/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 91, in main run_details = run(port, options, args, stderr) File "/Users/admin/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 452, in run run_details = manager.run(args) File "/Users/admin/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 228, in run needs_http=needs_http, needs_web_platform_test_server=needs_web_platform_test_server, needs_websockets=needs_websockets) File "/Users/admin/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 87, in __init__ self.start_servers() File "/Users/admin/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 219, in start_servers self._port.start_websocket_server() File "/Users/admin/WebKit/Tools/Scripts/webkitpy/port/base.py", line 1044, in start_websocket_server server.start() File "/Users/admin/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/http_server_base.py", line 95, in start self._prepare_config() File "/Users/admin/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py", line 118, in _prepare_config self._wsout = self._filesystem.open_text_file_for_writing(output_log) File "/Users/admin/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py", line 239, in open_text_file_for_writing return codecs.open(path, 'w', 'utf8') File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 884, in open file = __builtin__.open(filename, mode, buffering) IOError: [Errno 2] No such file or directory: u'/Users/admin/WebKit/WebKitBuild/Release/layout-test-results/pywebsocket.ws.log-out.txt' Comment on attachment 371206 [details] Patch Attachment 371206 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12365879 New failing tests: http/wpt/service-workers/service-worker-networkprocess-crash.html Created attachment 371213 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 371206 [details] Patch Attachment 371206 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12366770 New failing tests: fast/shadow-dom/svg-use-href-change-in-shadow-tree.html imported/blink/fast/canvas/bug382588.html Created attachment 371232 [details]
Archive of layout-test-results from ews211 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
If you can reproduce the issue and this fixes it, could you also revert https://trac.webkit.org/changeset/234933/webkit in the same patch? Created attachment 371355 [details]
Patch
Comment on attachment 371355 [details] Patch Attachment 371355 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12379424 New failing tests: http/tests/websocket/tests/hybi/deflate-frame-parameter.html Created attachment 371360 [details]
Archive of layout-test-results from ews215 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 371386 [details]
Patch
(In reply to Alex Christensen from comment #10) > If you can reproduce the issue and this fixes it, could you also revert > https://trac.webkit.org/changeset/234933/webkit in the same patch? The issue is easy to reproduce with: rm -rf WebKitBuild Tools/Scripts/build-webkit Tools/Scripts/run-webkit-tests --no-build I've also managed to reproduce "port 8880 is already in use" problem with: Tools/Scripts/run-webkit-websocketserver ENTER The latest patch fixes both issues and includes revert of changeset 234933. CI test fails seem irrelevant. Comment on attachment 371386 [details] Patch Attachment 371386 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12384132 New failing tests: imported/blink/fast/canvas/canvas-clip-stack-persistence.html http/tests/websocket/tests/hybi/deflate-frame-parameter.html imported/blink/fast/canvas/canvas-state-persistence-no-dirty.html Created attachment 371399 [details]
Archive of layout-test-results from ews211 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 371386 [details] Patch Attachment 371386 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12384637 New failing tests: http/tests/websocket/tests/hybi/deflate-frame-parameter.html Created attachment 371402 [details]
Archive of layout-test-results from ews212 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
(In reply to Build Bot from comment #18) > New failing tests: > http/tests/websocket/tests/hybi/deflate-frame-parameter.html Yep, this is definitely related. Created attachment 371443 [details]
Patch
Comment on attachment 371443 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371443&action=review r=me if this passes EWS. > Tools/ChangeLog:8 > + 1. Properly shutdown WebSocket server so that port 8880 is released. I don't see this change. (In reply to Alex Christensen from comment #22) > I don't see this change. This change is in `new-run-webkit-websocketserver` script. Does it work for you? I've updated the test expectations. In comparison with revision before 234933, 3 more tests now pass expectedly: http/tests/websocket/tests/hybi/simple-wss.html http/tests/websocket/tests/hybi/websocket-allowed-setting-cookie-as-third-party.html (webkit.org/b/187762) http/tests/websocket/tests/hybi/websocket-cookie-overwrite-behavior.html (webkit.org/b/187762) While 1 new test is failing: http/tests/websocket/tests/hybi/deflate-frame-parameter.html ok Comment on attachment 371443 [details] Patch Attachment 371443 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12389422 New failing tests: http/wpt/service-workers/service-worker-networkprocess-crash.html Created attachment 371453 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 371443 [details] Patch Attachment 371443 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12391593 New failing tests: http/tests/websocket/tests/hybi/websocket-cookie-overwrite-behavior.html Created attachment 371470 [details]
Archive of layout-test-results from ews212 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 371505 [details]
Patch
Comment on attachment 371505 [details] Patch Attachment 371505 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12396704 New failing tests: http/wpt/service-workers/service-worker-networkprocess-crash.html Created attachment 371508 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
(In reply to Alexey Shvayka from comment #29) > Created attachment 371505 [details] > Patch I've tweaked the expectations: http/tests/websocket/tests/hybi/websocket-cookie-overwrite-behavior.html test was failing on ews212, while passing on ews211. I'm also suffering from this issue since today. Here is my error message. PS C:\webkit\gb> python ./Tools/Scripts/run-webkit-tests --wincairo --release --no-new-test-results -1 Using port 'wincairo-win10' Test configuration: <win10, x86_64, release> Placing test results in C:\webkit\gb\WebKitBuild\Release\bin64\layout-test-results Using Release build Pixel tests disabled Regular timeout: 30000, slow test timeout: 150000 Command line: C:\webkit\gb\WebKitBuild\Release\bin64\DumpRenderTree.exe - Found 57947 tests; running 16525, skipping 41422. Failed to remove stale pywebsocket log files: [Error 3] The system cannot find the path specified: u'C:\\webkit\\gb\\WebKitBuild\\Release\\bin64\\layout-test-results\\*.*' IOError raised: [Errno 2] No such file or directory: u'C:\\webkit\\gb\\WebKitBuild\\Release\\bin64\\layout-test-results\\pywebsocket.ws.log-out.txt' Traceback (most recent call last): File "C:\webkit\gb\Tools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 91, in main run_details = run(port, options, args, stderr) File "C:\webkit\gb\Tools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 452, in run run_details = manager.run(args) File "C:\webkit\gb\Tools\Scripts\webkitpy\layout_tests\controllers\manager.py", line 229, in run needs_http=needs_http, needs_web_platform_test_server=needs_web_platform_test_server, needs_websockets=needs_websockets) File "C:\webkit\gb\Tools\Scripts\webkitpy\layout_tests\controllers\layout_test_runner.py", line 87, in __init__ self.start_servers() File "C:\webkit\gb\Tools\Scripts\webkitpy\layout_tests\controllers\layout_test_runner.py", line 219, in start_servers self._port.start_websocket_server() File "C:\webkit\gb\Tools\Scripts\webkitpy\port\base.py", line 1037, in start_websocket_server server.start() File "C:\webkit\gb\Tools\Scripts\webkitpy\layout_tests\servers\http_server_base.py", line 95, in start self._prepare_config() File "C:\webkit\gb\Tools\Scripts\webkitpy\layout_tests\servers\websocket_server.py", line 118, in _prepare_config self._wsout = self._filesystem.open_text_file_for_writing(output_log) File "C:\webkit\gb\Tools\Scripts\webkitpy\common\system\filesystem.py", line 240, in open_text_file_for_writing return codecs.open(path, 'w', 'utf8') File "C:\Python27\lib\codecs.py", line 898, in open file = __builtin__.open(filename, mode, buffering) IOError: [Errno 2] No such file or directory: u'C:\\webkit\\gb\\WebKitBuild\\Release\\bin64\\layout-test-results\\pywebsocket.ws.log-out.txt' In my case, the following conditions causes this issue: 1. check_httpd is failing because Apache service is already started 2. layout-test-results directory is not created yet Comment on attachment 371505 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371505&action=review > Tools/ChangeLog:12 > + (main): Tweak import and use class constants of PyWebSocket directly. Why is this change needed? Created attachment 379883 [details]
Patch
Rebased onto ToT. Submitted for EWS.
(In reply to Fujii Hironori from comment #35) > > Tools/ChangeLog:12 > > + (main): Tweak import and use class constants of PyWebSocket directly. > > Why is this change needed? This change is not necessary to fix the issue with missing directory, but it solves a couple of FIXMEs. Comment on attachment 379883 [details] Patch Clearing flags on attachment: 379883 Committed r250593: <https://trac.webkit.org/changeset/250593> All reviewed patches have been landed. Closing bug. |