| Summary: | Add Experimental Feature support for SourceBuffer.changeType() | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, jeremyj-wk, jonlee, realdawei, rniwa, ryanhaddad, tsavell, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Jer Noble
2018-08-15 16:28:34 PDT
Created attachment 347223 [details]
Patch
Comment on attachment 347223 [details] Patch Attachment 347223 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8874083 New failing tests: imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html imported/w3c/web-platform-tests/media-source/mediasource-changetype.html Created attachment 347233 [details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 347223 [details] Patch Attachment 347223 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8874164 New failing tests: imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html imported/w3c/web-platform-tests/media-source/mediasource-changetype.html Created attachment 347234 [details]
Archive of layout-test-results from ews115 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 347268 [details]
Patch for landing
Created attachment 347272 [details]
Patch for landing
Comment on attachment 347272 [details] Patch for landing Rejecting attachment 347272 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 347272, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/8882006 Committed r234940: <https://trac.webkit.org/changeset/234940> Looks like in: https://trac.webkit.org/changeset/234940/webkit The new test imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html is a flakey failure. History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fmedia-source%2Fmediasource-changetype-play.html Diff: --- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/legacy-animation-engine/animations/animation-direction-normal-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/legacy-animation-engine/animations/animation-direction-normal-actual.txt @@ -1,4 +1,4 @@ PASS - "webkitTransform" property for "box" element at 0.5s saw something close to: 1,0,0,1,50,0 -PASS - "webkitTransform" property for "box" element at 1s saw something close to: 1,0,0,1,100,0 +FAIL - "webkitTransform" property for "box" element at 1s expected: 1,0,0,1,100,0 but saw: matrix(1, 0, 0, 1, 129.1008758544922, 0) PASS - "webkitTransform" property for "box" element at 2.5s saw something close to: 1,0,0,1,50,0 This test is now showing flakey failures across all of debug and some release builds. The test has a harness timeout. Disregard previous posted diff. --- /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-actual.txt @@ -1,8 +1,10 @@ + +Harness Error (TIMEOUT), message = null FAIL Check if browser supports enough test media types assert_true: Browser doesn't support at least 2 types of video test media expected true got false PASS Test audio-only changeType for audio/mp4; codecs="mp4a.40.2" <-> audio/mp4; codecs="mp4a.40.2" -PASS Test audio-only changeType for audio/mp4; codecs="mp4a.40.2" <-> audio/mpeg +TIMEOUT Test audio-only changeType for audio/mp4; codecs="mp4a.40.2" <-> audio/mpeg Test timed out PASS Test audio-only changeType for audio/mpeg <-> audio/mp4; codecs="mp4a.40.2" -PASS Test audio-only changeType for audio/mpeg <-> audio/mpeg +TIMEOUT Test audio-only changeType for audio/mpeg <-> audio/mpeg Test timed out PASS Test video-only changeType for video/mp4; codecs="avc1.4D4001" <-> video/mp4; codecs="avc1.4D4001" I have a workable repro: run-webkit-tests --root debug-236084 imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html --iterations 500 -f --debug The test will have a failure less than 1/100 times. Tracking failure of imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html in https://bugs.webkit.org/show_bug.cgi?id=190976 closing this bug. |