Bug 188572 – check-webkit-style incorrectly complaint about Buildbot 1.0 methods

• Component: Tools / Tests
• Status: RESOLVED CONFIGURATION CHANGED

[Aakash Jain]

check-webkit-style uses code from webkitpy which uses Buildbot 0.8.6p1 (https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py#L197).

0.8.6p1 is the buildbot version used by build.webkit.org (and is very old version). However, in other portion of code (ews-build.webkit.org) we use latest Buildbot. There is significant difference in imports and functions signatures in Buildbot v0.8.6p1 and v1.0. Because of this check-webkit-style incorrectly complains about the code using Buildbot 1.0.

Sample error (https://bugs.webkit.org/show_bug.cgi?id=188498#c2):
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:777:  [TestRunWebKit1Tests.test_success] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:777:  [TestRunWebKit1Tests.test_success] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:791:  [TestRunWebKit1Tests.test_failure] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:791:  [TestRunWebKit1Tests.test_failure] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]

[Aakash Jain]

When we upgrade build.webkit.org to latest Buildbot, this issue will be automatically fixed.

[Aakash Jain]

One solution is to suppress these warnings by adding '-pylint/E1123' and '-pylint/E1120' to https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/style/checker.py#L118

However, it might suppress some real warnings as well.

[Lucas Forschler]

I think it's possible to suppress the warning on the line of source code as well... 
https://stackoverflow.com/questions/28829236/is-it-possible-to-ignore-one-single-specific-line-with-pylint

[Aakash Jain]

(In reply to Lucas Forschler from comment #3)
> I think it's possible to suppress the warning on the line of source code as
> well... 
> https://stackoverflow.com/questions/28829236/is-it-possible-to-ignore-one-
> single-specific-line-with-pylint


This works, however this would require adding the pylint disable statement for every line having Buildbot 1.0 related methods/imports. Would be few hundred such lines.

[Aakash Jain]

This issue no longer seems to be happening since we moved style queue to new EWS. ews bots have buildbot 1.0+ installed on them.

[Radar WebKit Bug Importer]

<rdar://problem/60722746>