Bug 188538

Summary: Allow the substring 'me' in contributor names and email addresses
Product: WebKit Reporter: Thomas Denney <tdenney>
Component: New BugsAssignee: Thomas Denney <tdenney>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, glenn, realdawei, rniwa, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Thomas Denney
Reported 2018-08-13 15:30:09 PDT
Allow the substring 'me' in contributor names and email addresses
Attachments
Patch (1.55 KB, patch)
2018-08-13 15:31 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
Patch (1.55 KB, patch)
2018-08-13 15:45 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Thomas Denney
Comment 1 2018-08-13 15:31:56 PDT
Created attachment 347050 [details] Patch
EWS Watchlist
Comment 2 2018-08-13 15:34:03 PDT
Attachment 347050 [details] did not pass style-queue: ERROR: Tools/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] ERROR: Tools/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] ERROR: Tools/ChangeLog:8: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzz test [changelog/unwantedsecurityterms] [3] Total errors found: 3 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2018-08-13 15:38:46 PDT
Comment on attachment 347050 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347050&action=review Other than that r=me > Tools/ChangeLog:8 > + A fuzz test didn't permit the string "me" in email addresses or names of TABS‽ TABS‽
Thomas Denney
Comment 4 2018-08-13 15:45:18 PDT
Created attachment 347052 [details] Patch
Tim Horton
Comment 5 2018-08-13 15:47:34 PDT
(In reply to Build Bot from comment #2) > security-sensitive phrasing could help someone exploit WebKit: fuzz test > [changelog/unwantedsecurityterms] [3] HA
WebKit Commit Bot
Comment 6 2018-08-13 16:15:12 PDT
Comment on attachment 347052 [details] Patch Clearing flags on attachment: 347052 Committed r234824: <https://trac.webkit.org/changeset/234824>
WebKit Commit Bot
Comment 7 2018-08-13 16:15:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-08-13 16:17:17 PDT
<rdar://problem/43258117>
Note You need to log in before you can comment on or make changes to this bug.