Bug 188473

Summary: webkit-patch setup-git-clone should set Git core editor to commit-log-editor
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, glenn, lforschler, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2018-08-10 10:01:38 PDT
We should have "webkit-patch setup-git-clone" configure the Git core editor to use Tools/Scripts/commit-log-editor. This will ensure that the Git commit message will have the proper format for developers that choose to manually generate their ChangeLog using prepare-ChangeLog.
Attachments
Patch (2.19 KB, patch)
2018-08-10 10:05 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-08-10 10:05:22 PDT
Created attachment 346907 [details] Patch
Daniel Bates
Comment 2 2018-08-10 14:48:45 PDT
Comment on attachment 346907 [details] Patch Clearing flags on attachment: 346907 Committed r234770: <https://trac.webkit.org/changeset/234770>
Daniel Bates
Comment 3 2018-08-10 14:48:47 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-08-10 14:49:17 PDT
<rdar://problem/43157814>
Note You need to log in before you can comment on or make changes to this bug.