Bug 188462

Summary: Add ability to ignore process prewarming for launch time benchmark
Product: WebKit Reporter: Ben Richards <benton_richards>
Component: New BugsAssignee: Ben Richards <benton_richards>
Status: RESOLVED FIXED    
Severity: Normal CC: benton_richards, cdumez, commit-queue, ews-feeder, ews-watchlist, ggaren, rniwa, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ben Richards
Reported 2018-08-09 17:48:57 PDT
Add ability to ignore process prewarming for launch time benchmark
Attachments
Patch (9.47 KB, patch)
2018-08-09 18:11 PDT, Ben Richards 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ben Richards
Comment 1 2018-08-09 18:11:43 PDT
Created attachment 346883 [details] Patch
WebKit Commit Bot
Comment 2 2018-08-09 21:53:49 PDT
Comment on attachment 346883 [details] Patch Clearing flags on attachment: 346883 Committed r234750: <https://trac.webkit.org/changeset/234750>
WebKit Commit Bot
Comment 3 2018-08-09 21:53:50 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-08-09 21:54:20 PDT
<rdar://problem/43126381>
Truitt Savell
Comment 5 2018-08-10 09:26:17 PDT
Reverted r234750 for reason: Caused 185 perf test failures. Committed r234757: <https://trac.webkit.org/changeset/234757>
Truitt Savell
Comment 6 2018-08-10 10:35:26 PDT
(In reply to Truitt Savell from comment #5) > Reverted r234750 for reason: > > Caused 185 perf test failures. > > Committed r234757: <https://trac.webkit.org/changeset/234757> I apologize, I was wrong with this rollout.
Ben Richards
Comment 7 2018-08-10 10:48:31 PDT
No worries. Can we reland this?
Truitt Savell
Comment 8 2018-08-10 10:49:30 PDT
yes we should land it again
EWS
Comment 9 2018-08-10 10:51:43 PDT
Comment on attachment 346883 [details] Patch Rejecting attachment 346883 [details] from commit-queue. benton_richards@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Commit Bot
Comment 10 2018-08-10 10:55:50 PDT
Comment on attachment 346883 [details] Patch Rejecting attachment 346883 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 346883, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in PerformanceTests/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/8820578
WebKit Commit Bot
Comment 11 2018-08-10 11:23:56 PDT
Comment on attachment 346883 [details] Patch Clearing flags on attachment: 346883 Committed r234764: <https://trac.webkit.org/changeset/234764>
WebKit Commit Bot
Comment 12 2018-08-10 11:23:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.