Bug 188456

Summary: [Curl] Test gardening
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: Tools / TestsAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: basuke, commit-queue, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
PATCH
commit-queue: commit-queue-
PATCH none

Basuke Suzuki
Reported 2018-08-09 16:20:24 PDT
Unskip xmlhttprequest.
Attachments
PATCH (5.65 KB, patch)
2018-08-09 16:32 PDT, Basuke Suzuki 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
PATCH (39.98 KB, patch)
2018-08-09 16:40 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2018-08-09 16:32:59 PDT
Created attachment 346871 [details] PATCH
WebKit Commit Bot
Comment 2 2018-08-09 16:34:41 PDT
Comment on attachment 346871 [details] PATCH Rejecting attachment 346871 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 346871, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=346871&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=188456&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 346871 from bug 188456. Fetching: https://bugs.webkit.org/attachment.cgi?id=346871 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 25 cwd: /Volumes/Data/EWS/WebKit Error: the Git diff contains a binary file without the binary data in line: "Binary files /dev/null and b/LayoutTests/platform/wincairo/http/tests/local/file-url-sent-as-referer-expected.png differ". Be sure to use the --binary flag when invoking "git diff" with diffs containing binary files. at /Volumes/Data/EWS/WebKit/Tools/Scripts/VCSUtils.pm line 870, <ARGV> line 83. Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 25 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/8813307
Basuke Suzuki
Comment 3 2018-08-09 16:40:23 PDT
Created attachment 346874 [details] PATCH
WebKit Commit Bot
Comment 4 2018-08-09 17:19:04 PDT
Comment on attachment 346874 [details] PATCH Clearing flags on attachment: 346874 Committed r234745: <https://trac.webkit.org/changeset/234745>
WebKit Commit Bot
Comment 5 2018-08-09 17:19:06 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-08-09 17:20:20 PDT
<rdar://problem/43118839>
Note You need to log in before you can comment on or make changes to this bug.