Update IDL for IntersectionObserverEntry and IntersectionObserverEntryInit

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Ali Juma]

Update IntersectionObserverEntry by adding |isIntersecting| and making |rootBounds| nullable. Make the same changes to IntersectionObserverEntryInit, and also add intersectionRatio.

[Ali Juma]

Created attachment 346847 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 346847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346847&action=review

> Source/WebCore/page/IntersectionObserverEntry.h:51
> +        std::optional<DOMRectInit> rootBounds;
>          DOMRectInit boundingClientRect;
>          DOMRectInit intersectionRect;
> +        bool isIntersecting;
> +        double intersectionRatio;
>          RefPtr<Element> target;

This would pack better if you put the bool at the end

> Source/WebCore/page/IntersectionObserverEntry.h:77
> +    bool m_isIntersecting { false };
>      double m_intersectionRatio { 0 };
>      RefPtr<Element> m_target;

Ditto

[Ali Juma]

Created attachment 346851 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 346851 [details]
Patch for landing

Clearing flags on attachment: 346851

Committed r234732: <https://trac.webkit.org/changeset/234732>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/43106234>