Bug 188445

Summary: Update IDL for IntersectionObserverEntry and IntersectionObserverEntryInit
Product: WebKit Reporter: Ali Juma <ajuma>
Component: Layout and RenderingAssignee: Ali Juma <ajuma>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, esprehn+autocc, ews-watchlist, kondapallykalyan, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 159475    
Attachments:
Description Flags
Patch
none
Patch for landing none

Ali Juma
Reported 2018-08-09 11:03:22 PDT
Update IntersectionObserverEntry by adding |isIntersecting| and making |rootBounds| nullable. Make the same changes to IntersectionObserverEntryInit, and also add intersectionRatio.
Attachments
Patch (8.34 KB, patch)
2018-08-09 11:09 PDT, Ali Juma 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.31 KB, patch)
2018-08-09 11:26 PDT, Ali Juma 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ali Juma
Comment 1 2018-08-09 11:09:42 PDT
Created attachment 346847 [details] Patch
Simon Fraser (smfr)
Comment 2 2018-08-09 11:15:28 PDT
Comment on attachment 346847 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346847&action=review > Source/WebCore/page/IntersectionObserverEntry.h:51 > + std::optional<DOMRectInit> rootBounds; > DOMRectInit boundingClientRect; > DOMRectInit intersectionRect; > + bool isIntersecting; > + double intersectionRatio; > RefPtr<Element> target; This would pack better if you put the bool at the end > Source/WebCore/page/IntersectionObserverEntry.h:77 > + bool m_isIntersecting { false }; > double m_intersectionRatio { 0 }; > RefPtr<Element> m_target; Ditto
Ali Juma
Comment 3 2018-08-09 11:26:29 PDT
Created attachment 346851 [details] Patch for landing
WebKit Commit Bot
Comment 4 2018-08-09 12:36:45 PDT
Comment on attachment 346851 [details] Patch for landing Clearing flags on attachment: 346851 Committed r234732: <https://trac.webkit.org/changeset/234732>
WebKit Commit Bot
Comment 5 2018-08-09 12:36:47 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-08-09 12:37:19 PDT
<rdar://problem/43106234>
Note You need to log in before you can comment on or make changes to this bug.