Bug 188439

Summary: [iOS WK2] Rename and refactor DataInteractionTests and DataInteractionSimulator
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: Tools / TestsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, commit-queue, lforschler, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix macOS builds
none
Rename to DragAndDropSimulator
aestes: review+
Patch for landing none

Wenson Hsieh
Reported 2018-08-09 08:09:11 PDT
Rename DataInteractionSimulator to DraggingSimulator, and make DraggingSimulator cross-platform.
Attachments
Patch (290.83 KB, patch)
2018-08-09 08:17 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix macOS builds (291.11 KB, patch)
2018-08-09 08:41 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Rename to DragAndDropSimulator (300.34 KB, patch)
2018-08-09 09:45 PDT, Wenson Hsieh 		aestes: review+
DetailsFormatted DiffDiff
Patch for landing (300.36 KB, patch)
2018-08-09 11:21 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-08-09 08:17:12 PDT
Created attachment 346836 [details] Patch
Wenson Hsieh
Comment 2 2018-08-09 08:41:50 PDT
Created attachment 346837 [details] Fix macOS builds
Megan Gardner
Comment 3 2018-08-09 09:38:16 PDT
DragAndDropSimulator seems like it would be a better rename than just DraggingSimulator, since we are simulating both dragging and dropping.
Wenson Hsieh
Comment 4 2018-08-09 09:40:44 PDT
(In reply to Megan Gardner from comment #3) > DragAndDropSimulator seems like it would be a better rename than just > DraggingSimulator, since we are simulating both dragging and dropping. I considered this, but went with DraggingSimulator because it sounded more pleasant. But I don't have strong opinions either way — I'll go with DragAndDropSimulator.
Wenson Hsieh
Comment 5 2018-08-09 09:45:34 PDT
Created attachment 346838 [details] Rename to DragAndDropSimulator
Megan Gardner
Comment 6 2018-08-09 09:48:16 PDT
r=me unofficial
Andy Estes
Comment 7 2018-08-09 10:19:46 PDT
Comment on attachment 346838 [details] Rename to DragAndDropSimulator rs=me
Wenson Hsieh
Comment 8 2018-08-09 11:21:51 PDT
Created attachment 346849 [details] Patch for landing
WebKit Commit Bot
Comment 9 2018-08-09 12:02:28 PDT
Comment on attachment 346849 [details] Patch for landing Clearing flags on attachment: 346849 Committed r234731: <https://trac.webkit.org/changeset/234731>
Radar WebKit Bug Importer
Comment 10 2018-10-01 13:56:41 PDT
<rdar://problem/44919982>
Note You need to log in before you can comment on or make changes to this bug.