Bug 188390

Summary: REGRESSION(r234669): Didn't commit the actual change (Requested by rniwa on #webkit).
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: fred.wang, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 187319    
Attachments:
Description Flags
ROLLOUT of r234669 none

WebKit Commit Bot
Reported 2018-08-07 14:20:55 PDT
https://trac.webkit.org/changeset/234669 broke the build: Didn't commit the actual change (Requested by rniwa on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
ROLLOUT of r234669 (20.18 KB, patch)
2018-08-07 14:21 PDT, WebKit Commit Bot 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2018-08-07 14:21:01 PDT
Created attachment 346734 [details] ROLLOUT of r234669 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Ryosuke Niwa
Comment 2 2018-08-07 14:23:21 PDT
On interesting, this did commit the tests.
WebKit Commit Bot
Comment 3 2018-08-07 14:28:54 PDT
Comment on attachment 346734 [details] ROLLOUT of r234669 Clearing flags on attachment: 346734 Committed r234670: <https://trac.webkit.org/changeset/234670>
WebKit Commit Bot
Comment 4 2018-08-07 14:28:55 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-08-07 14:30:14 PDT
<rdar://problem/43020847>
Note You need to log in before you can comment on or make changes to this bug.