Bug 188369

Summary: Removed unused *AllInOne.cpp
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ysuzuki: review+, commit-queue: commit-queue-
Archive of layout-test-results from ews200 for win-future none

Alex Christensen
Reported 2018-08-06 18:00:03 PDT
Removed unused *AllInOne.cpp
Attachments
Patch (58.50 KB, patch)
2018-08-06 18:01 PDT, Alex Christensen 		ysuzuki: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews200 for win-future (12.82 MB, application/zip)
2018-08-07 07:42 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-08-06 18:01:15 PDT
Created attachment 346671 [details] Patch
EWS Watchlist
Comment 2 2018-08-06 18:03:25 PDT
Attachment 346671 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 3 2018-08-06 18:55:18 PDT
Comment on attachment 346671 [details] Patch r=me
WebKit Commit Bot
Comment 4 2018-08-06 18:59:24 PDT
Comment on attachment 346671 [details] Patch Rejecting attachment 346671 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 346671, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/8782707
EWS Watchlist
Comment 5 2018-08-07 07:41:52 PDT
Comment on attachment 346671 [details] Patch Attachment 346671 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8787687 New failing tests: http/tests/security/local-video-source-from-remote.html
EWS Watchlist
Comment 6 2018-08-07 07:42:04 PDT
Created attachment 346708 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Alex Christensen
Comment 7 2018-08-07 10:15:41 PDT
http://trac.webkit.org/r234655
Radar WebKit Bug Importer
Comment 8 2018-08-07 10:16:26 PDT
<rdar://problem/43009090>
Note You need to log in before you can comment on or make changes to this bug.