Bug 188356 – De-flake some animation tests

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

De-flake some animation tests

[Simon Fraser (smfr)]

Created attachment 346653 [details]
Patch

[Simon Fraser (smfr)]

Antoine, why doesn't compositing/visible-rect/animated-from-none.html have the <!-- webkit-test-runner [ enableWebAnimationsCSSIntegration=true ] --> ?

[Dean Jackson]

Comment on attachment 346653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346653&action=review

> LayoutTests/compositing/visible-rect/animated-from-none.html:38
> +            animated.addEventListener('webkitAnimationStart', function() {

Can be animationstart

> LayoutTests/compositing/visible-rect/animated.html:40
> +            animated.addEventListener('webkitAnimationStart', function() {

Ditto.

[WebKit Commit Bot]

Comment on attachment 346653 [details]
Patch

Rejecting attachment 346653 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 346653, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=346653&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=188356&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 346653 from bug 188356.
Fetching: https://bugs.webkit.org/attachment.cgi?id=346653
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/LayoutTests/ChangeLog' is out of date
W: 87d5bc62303f5333b2e24243136f1dc87622a368 and refs/remotes/origin/master differ, using rebase:
:040000 040000 c6e36a9700d077d72373475d3468a0c6183f6e4b 9cdc6db6a8dbdf0098bb0b34b81fd7487692d566 M	LayoutTests
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/LayoutTests/ChangeLog' is out of date
W: 87d5bc62303f5333b2e24243136f1dc87622a368 and refs/remotes/origin/master differ, using rebase:
:040000 040000 c6e36a9700d077d72373475d3468a0c6183f6e4b 9cdc6db6a8dbdf0098bb0b34b81fd7487692d566 M	LayoutTests
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   bb7abf9e0f2..1a0f376f55c  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 234636 = bb7abf9e0f2e04467febcc9594f5a1dcef5058dd
r234637 = 1a0f376f55cd7e733aef22d35d21857c8eb92931
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/8782018

[WebKit Commit Bot]

Comment on attachment 346653 [details]
Patch

Clearing flags on attachment: 346653

Committed r234641: <https://trac.webkit.org/changeset/234641>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/42992420>

[Antoine Quint]

(In reply to Simon Fraser (smfr) from comment #2)
> Antoine, why doesn't compositing/visible-rect/animated-from-none.html have
> the <!-- webkit-test-runner [ enableWebAnimationsCSSIntegration=true ] --> ?

Some test don't have that yet because they worked equally with or without the flag on. When we _finally_ turn Web Animations on by default on trunk (sometime in the second half of September is the current plan) then this won't be necessary anymore.