| Summary: | [libwebrtc] SafeSetError() in peerconnection.cc contains use-after-move of webrtc::RTCError variable | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Component: | WebRTC | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, commit-queue, eric.carlson, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.chromium.org/p/webrtc/issues/detail?id=9593 | ||||||
| Attachments: |
|
||||||
Created attachment 346609 [details]
Patch v1
Comment on attachment 346609 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=346609&action=review > Source/ThirdParty/libwebrtc/ChangeLog:4 > + [libwebrtc] SafeSetError() in peerconnection.cc contains use-after-move of webrtc::RTCError variable > + <https://webkit.org/b/188337> Shouldn't this include the bugzilla link? Comment on attachment 346609 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=346609&action=review >> Source/ThirdParty/libwebrtc/ChangeLog:4 >> + <https://webkit.org/b/188337> > > Shouldn't this include the bugzilla link? That redirects to the bugzilla link. :) I use it because it's shorter. Comment on attachment 346609 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=346609&action=review >>> Source/ThirdParty/libwebrtc/ChangeLog:4 >>> + <https://webkit.org/b/188337> >> >> Shouldn't this include the bugzilla link? > > That redirects to the bugzilla link. :) I use it because it's shorter. Ha ha, I meant to say "shouldn't this include the *Radar* link" :-). Comment on attachment 346609 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=346609&action=review >>>> Source/ThirdParty/libwebrtc/ChangeLog:4 >>>> + <https://webkit.org/b/188337> >>> >>> Shouldn't this include the bugzilla link? >> >> That redirects to the bugzilla link. :) I use it because it's shorter. > > Ha ha, I meant to say "shouldn't this include the *Radar* link" :-). Oops! Will try to stop commit queue. Committed r234690: <https://trac.webkit.org/changeset/234690> |
SafeSetError() in peerconnection.cc contains use-after-move of webrtc::RTCError variable: bool SafeSetError(webrtc::RTCError error, webrtc::RTCError* error_out) { if (error_out) { *error_out = std::move(error); } return error.ok(); } Seems like error.ok() should be read before the std::move(), or *error_out.ok() or error_out->ok() should be used instead. <rdar://problem/42882908>