| Summary: | [iOS] Caret disappears after resigning and becoming first responder if active focus state is retained | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||||||||||
| Component: | HTML Editing | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | bdakin, commit-queue, darin, ews-watchlist, megan_gardner, realdawei, ryanhaddad, sam, simon.fraser, thorton, tsavell, webkit-bug-importer, wenson_hsieh, zhaque | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=190821 | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Wenson Hsieh
2018-08-03 16:38:06 PDT
Began happening after r230745. Causes the caret to disappear in iOS Safari on iPad if the user taps the URL bar, and then the page. Created attachment 346566 [details]
Patch
Created attachment 346569 [details]
Fix macOS builds
Comment on attachment 346569 [details] Fix macOS builds Attachment 346569 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8763987 New failing tests: editing/selection/ios/selection-handles-after-touch-end.html imported/blink/transitions/unprefixed-transform.html Created attachment 346595 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 346596 [details]
Tweak Windows TestExpectations
Comment on attachment 346596 [details] Tweak Windows TestExpectations Attachment 346596 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8764498 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html legacy-animation-engine/imported/blink/transitions/unprefixed-transform.html Created attachment 346597 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 346596 [details] Tweak Windows TestExpectations View in context: https://bugs.webkit.org/attachment.cgi?id=346596&action=review > LayoutTests/ChangeLog:10 > + Adds a new layout test to verify that (1) selection handles are not shown when selecting a word by long > + pressing prior to ending the touch, and (2) selection handles are shown after ending the touch. V. nice. Comment on attachment 346596 [details]
Tweak Windows TestExpectations
Thanks for the review!
Comment on attachment 346596 [details] Tweak Windows TestExpectations Clearing flags on attachment: 346596 Committed r234600: <https://trac.webkit.org/changeset/234600> All reviewed patches have been landed. Closing bug. Comment on attachment 346596 [details] Tweak Windows TestExpectations View in context: https://bugs.webkit.org/attachment.cgi?id=346596&action=review > Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:127 > + auto expectedCaretRect = CGRectMake(16, 13, 3, 15); Oops, this test expectation is actually wrong (I missed updating the expected width after adding some logic to convert the caret rect to content view coordinates). I'll put out a fix for this in a bit... Reopening to attach new patch. Created attachment 346635 [details]
Adjust the API test
Comment on attachment 346635 [details] Adjust the API test Clearing flags on attachment: 346635 Committed r234614: <https://trac.webkit.org/changeset/234614> All reviewed patches have been landed. Closing bug. Comment on attachment 346635 [details] Adjust the API test View in context: https://bugs.webkit.org/attachment.cgi?id=346635&action=review > Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:41 > + return CGRectMake(roundl(rect.origin.x), roundl(rect.origin.y), roundl(rect.size.width), roundl(rect.size.height)); The use of roundl here is peculiar and almost certainly wrong; that function is the version that takes and returns a long double. Why are we converting these doubles to long doubles? I suggest using std::round here, which is overloaded for various types rather than the C round where you have to use the correct name for each type. Separately, I am really unclear why rounding to integers is the right thing to do. But it’s in a test so I won’t probe too hard on that question. Comment on attachment 346635 [details] Adjust the API test View in context: https://bugs.webkit.org/attachment.cgi?id=346635&action=review >> Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:41 >> + return CGRectMake(roundl(rect.origin.x), roundl(rect.origin.y), roundl(rect.size.width), roundl(rect.size.height)); > > The use of roundl here is peculiar and almost certainly wrong; that function is the version that takes and returns a long double. Why are we converting these doubles to long doubles? I suggest using std::round here, which is overloaded for various types rather than the C round where you have to use the correct name for each type. > > Separately, I am really unclear why rounding to integers is the right thing to do. But it’s in a test so I won’t probe too hard on that question. Got it — I'll change this to std::round. I'm rounding here because the caret view's frame converted to content view coordinates is very close to (but not exactly) {{ 16, 13 }, { 2, 15 }}. Reopening to attach new patch. Created attachment 346682 [details]
Patch
Comment on attachment 346682 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346682&action=review > Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:36 > +#import <wtf/MathExtras.h> I think <cmath> would be fine here. Comment on attachment 346682 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346682&action=review >> Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:36 >> +#import <wtf/MathExtras.h> > > I think <cmath> would be fine here. 👍 https://trac.webkit.org/changeset/234657/webkit(In reply to Sam Weinig from comment #22) > Comment on attachment 346682 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=346682&action=review > > > Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:36 > > +#import <wtf/MathExtras.h> > > I think <cmath> would be fine here. Committed r234657: <https://trac.webkit.org/changeset/234657/webkit> |