Summary: | Toggling "display: contents" to "display: none" fails to hide the element | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Sieradski <daniel> | ||||||||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Major | CC: | commit-queue, eloy.de.enige, ericxgao1, ews-watchlist, joepeck, jonlee, koivisto, m.goleb+bugzilla, rniwa, saam, sabouhallawa, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | Safari 11 | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Attachments: |
|
Description
Daniel Sieradski
2018-08-02 08:25:04 PDT
The URL where you can tinker with this is: https://nylon.com/articles/nylon-beauty-hit-list-awards-2018 Sorry, I meant to write, "This works properly in Firefox and Chrome on desktop." It also works in Edge. This appears to be specifically related to the use of "display: contents;". If I switch it to "display: block;" then it works fine. Hi Daniel, thanks for the bug report. I’ve CCd some folks who should be able to figure out what’s going on display:contents bug. I can't reproduce with that page, it doesn't appear to use display:contents. Daniel, do you have a test case for this? Sorry, once I figured out a fix, I had to implement it. I can put a rolled-back version up on a staging server if you only need it for a little bit. Please do (or make a small test case if you can). You can find a reproduction here https://codepen.io/alloy/pen/rQWmYG. Resize the width of the window to see that on Safari all elements stay visible, once visible. On Chrome only 1 element is visible at a time. Btw, I’m seeing this on Safari 12 and the TP build of November 7th. Yeah, I can reproduce the problem now. Any progress on this? I have made a CodePen with a far simpler test case. https://codepen.io/ericxgao/pen/dreqWp Go in and inspect the text in Safari 12 - changing the class from "contents" to "hide" does nothing. Created attachment 365065 [details]
Reduction
Created attachment 365066 [details]
Even simpler reduction
Created attachment 365857 [details]
patch
Comment on attachment 365857 [details] patch Attachment 365857 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11659182 New failing tests: http/tests/preload/download_resources_from_header_iframe.html Created attachment 365859 [details]
Archive of layout-test-results from ews202 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment on attachment 365857 [details] patch Clearing flags on attachment: 365857 Committed r243444: <https://trac.webkit.org/changeset/243444> All reviewed patches have been landed. Closing bug. |