Summary: | httpCookieStore.getAllCookies() does not always call completion block | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||||
Component: | WebKit2 | Assignee: | Sihui Liu <sihui_liu> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, ews-watchlist, ggaren, rniwa, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Sihui Liu
2018-08-01 15:59:00 PDT
Created attachment 346310 [details]
Patch
Comment on attachment 346310 [details] Patch Attachment 346310 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8734158 New failing tests: imported/blink/transitions/unprefixed-transform.html legacy-animation-engine/imported/blink/transitions/unprefixed-transform.html Created attachment 346359 [details]
Archive of layout-test-results from ews205 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 346310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346310&action=review r=me with nits. > Source/WebKit/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=188242 Is there a radar tracking this as well? > Source/WebKit/UIProcess/GenericCallback.h:199 > CallbackID put(Function<void(T...)>&& function) Is anyone still relying on this overload? If not, we should probably drop it. > Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:113 > + auto callbackID = m_callbacks.put(WTFMove(callbackFunction), processPool()->networkProcess()->throttler().backgroundActivityToken()); processPool()->ensureNetworkProcess().throttler().backgroundActivityToken() Then omit the line above. > Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:140 > + processPool()->ensureNetworkProcess(); ditto. > Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:147 > + processPool()->ensureNetworkProcess(); ditto. > Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:154 > + processPool()->ensureNetworkProcess(); ditto. > Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:161 > + processPool()->ensureNetworkProcess(); ditto. > Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:168 > + processPool()->ensureNetworkProcess(); ditto. > Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:175 > + processPool()->ensureNetworkProcess(); ditto. > Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:262 > + processPool()->ensureNetworkProcess(); ditto. > Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:269 > + processPool()->ensureNetworkProcess(); ditto. (In reply to Chris Dumez from comment #4) > Comment on attachment 346310 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=346310&action=review > > r=me with nits. > > > Source/WebKit/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=188242 > > Is there a radar tracking this as well? > I think it's <rdar://problem/33122061>. > > Source/WebKit/UIProcess/GenericCallback.h:199 > > CallbackID put(Function<void(T...)>&& function) > > Is anyone still relying on this overload? If not, we should probably drop it. > No, so dropping. > > Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:113 > > + auto callbackID = m_callbacks.put(WTFMove(callbackFunction), processPool()->networkProcess()->throttler().backgroundActivityToken()); > > processPool()->ensureNetworkProcess().throttler().backgroundActivityToken() > Then omit the line above. > > > Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:140 > > + processPool()->ensureNetworkProcess(); > > ditto. > Done. > > Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:147 > > + processPool()->ensureNetworkProcess(); > > ditto. > Done. > > Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:154 > > + processPool()->ensureNetworkProcess(); > > ditto. > Done. > > Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:161 > > + processPool()->ensureNetworkProcess(); > > ditto. > Done. > > Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:168 > > + processPool()->ensureNetworkProcess(); > > ditto. > Done. > > Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:175 > > + processPool()->ensureNetworkProcess(); > > ditto. > Done. > > Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:262 > > + processPool()->ensureNetworkProcess(); > > ditto. > Done. > > Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:269 > > + processPool()->ensureNetworkProcess(); > > ditto. Done. Created attachment 346419 [details]
Patch for landing
*** Bug 174007 has been marked as a duplicate of this bug. *** Comment on attachment 346419 [details] Patch for landing Clearing flags on attachment: 346419 Committed r234518: <https://trac.webkit.org/changeset/234518> All reviewed patches have been landed. Closing bug. |