| Summary: | [iOS] Color picker should have a border when presented in a popover | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aditya Keerthi <pxlcoder> | ||||||||
| Component: | Forms | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, thorton, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | iPhone / iPad | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 188124 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Aditya Keerthi
2018-07-31 15:59:29 PDT
Created attachment 346213 [details]
Patch
Comment on attachment 346213 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346213&action=review > Source/WebKit/UIProcess/ios/forms/WKFormColorControl.mm:58 > + RetainPtr<UIView> controlContainerView = [[UIView alloc] initWithFrame:CGRectMake(0, 0, colorPopoverWidth, colorPopoverWidth)]; adoptNS! Created attachment 346214 [details]
Patch
Will rebase this patch on trunk once 188124 is in. Comment on attachment 346214 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346214&action=review > Source/WebKit/ChangeLog:11 > + Since the popover will resize it's view to fill it's size, we first place the Super nit — it's => its > Source/WebKit/ChangeLog:13 > + while the smaller color picker is centered in it's container - creating the Here too. Created attachment 346279 [details]
Patch
Comment on attachment 346279 [details] Patch Clearing flags on attachment: 346279 Committed r234461: <https://trac.webkit.org/changeset/234461> All reviewed patches have been landed. Closing bug. |