Bug 188207

Summary: [iOS] Color picker should have a border when presented in a popover
Product: WebKit Reporter: Aditya Keerthi <pxlcoder>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: iPhone / iPad   
OS: Unspecified   
Bug Depends on: 188124    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Aditya Keerthi
Reported 2018-07-31 15:59:29 PDT
The color picker should have a border when presented in a popover (on iPad).
Attachments
Patch (3.65 KB, patch)
2018-07-31 16:06 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (3.66 KB, patch)
2018-07-31 16:13 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (3.57 KB, patch)
2018-08-01 09:07 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2018-07-31 16:06:18 PDT
Created attachment 346213 [details] Patch
Wenson Hsieh
Comment 2 2018-07-31 16:09:26 PDT
Comment on attachment 346213 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346213&action=review > Source/WebKit/UIProcess/ios/forms/WKFormColorControl.mm:58 > + RetainPtr<UIView> controlContainerView = [[UIView alloc] initWithFrame:CGRectMake(0, 0, colorPopoverWidth, colorPopoverWidth)]; adoptNS!
Aditya Keerthi
Comment 3 2018-07-31 16:13:24 PDT
Created attachment 346214 [details] Patch
Aditya Keerthi
Comment 4 2018-07-31 16:13:52 PDT
Will rebase this patch on trunk once 188124 is in.
Wenson Hsieh
Comment 5 2018-07-31 16:37:34 PDT
Comment on attachment 346214 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346214&action=review > Source/WebKit/ChangeLog:11 > + Since the popover will resize it's view to fill it's size, we first place the Super nit — it's => its > Source/WebKit/ChangeLog:13 > + while the smaller color picker is centered in it's container - creating the Here too.
Aditya Keerthi
Comment 6 2018-08-01 09:07:53 PDT
Created attachment 346279 [details] Patch
WebKit Commit Bot
Comment 7 2018-08-01 10:26:24 PDT
Comment on attachment 346279 [details] Patch Clearing flags on attachment: 346279 Committed r234461: <https://trac.webkit.org/changeset/234461>
WebKit Commit Bot
Comment 8 2018-08-01 10:26:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-08-01 20:26:43 PDT
<rdar://problem/42840315>
Note You need to log in before you can comment on or make changes to this bug.