| Summary: | [JSC] Remove unnecessary cellLock() in JSObject's GC marking if IndexingType is contiguous | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2018-07-31 11:16:50 PDT
Created attachment 346181 [details]
Patch
Comment on attachment 346181 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346181&action=review r=me. > Source/JavaScriptCore/runtime/JSObject.cpp:400 > + // that can happen when the butterfly is used for array storage. Nit: Add a comment here repeating what you said in the change log about always reallocating the butterfly when converting to ArrayStorage. Comment on attachment 346181 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346181&action=review Thanks! >> Source/JavaScriptCore/runtime/JSObject.cpp:400 >> + // that can happen when the butterfly is used for array storage. > > Nit: Add a comment here repeating what you said in the change log about always reallocating the butterfly when converting to ArrayStorage. Sounds nice. Added. Committed r234434: <https://trac.webkit.org/changeset/234434> |