Bug 188201

Summary: [JSC] Remove unnecessary cellLock() in JSObject's GC marking if IndexingType is contiguous
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch keith_miller: review+

Yusuke Suzuki
Reported 2018-07-31 11:16:50 PDT
[JSC] Remove unnecessary cellLock() in JSObject's GC marking if IndexingType is contiguous
Attachments
Patch (2.20 KB, patch)
2018-07-31 11:19 PDT, Yusuke Suzuki 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-07-31 11:19:41 PDT
Created attachment 346181 [details] Patch
Keith Miller
Comment 2 2018-07-31 11:34:02 PDT
Comment on attachment 346181 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346181&action=review r=me. > Source/JavaScriptCore/runtime/JSObject.cpp:400 > + // that can happen when the butterfly is used for array storage. Nit: Add a comment here repeating what you said in the change log about always reallocating the butterfly when converting to ArrayStorage.
Yusuke Suzuki
Comment 3 2018-07-31 11:39:17 PDT
Comment on attachment 346181 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346181&action=review Thanks! >> Source/JavaScriptCore/runtime/JSObject.cpp:400 >> + // that can happen when the butterfly is used for array storage. > > Nit: Add a comment here repeating what you said in the change log about always reallocating the butterfly when converting to ArrayStorage. Sounds nice. Added.
Yusuke Suzuki
Comment 4 2018-07-31 11:48:49 PDT
Committed r234434: <https://trac.webkit.org/changeset/234434>
Radar WebKit Bug Importer
Comment 5 2018-07-31 11:49:26 PDT
<rdar://problem/42781022>
Note You need to log in before you can comment on or make changes to this bug.