Bug 188188 – [LFC] Add FormattingContext::mapToAncestor geometry mapping function

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

ssia

[alan]

Created attachment 346142 [details]
Patch

[alan]

Created attachment 346143 [details]
Patch

[alan]

Created attachment 346251 [details]
Patch

[EWS Watchlist]

Comment on attachment 346251 [details]
Patch

Attachment 346251 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8723424

New failing tests:
imported/blink/transitions/unprefixed-transform.html

[EWS Watchlist]

Created attachment 346277 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Antti Koivisto]

Comment on attachment 346251 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346251&action=review

> Source/WebCore/layout/displaytree/DisplayBox.cpp:142
> +Box Box::clone() const
> +{
> +    Box box;
> +    box.m_style = m_style;
> +
> +    box.m_topLeft = m_topLeft;
> +    box.m_contentWidth = m_contentWidth;
> +    box.m_contentHeight = m_contentHeight;
> +    box.m_verticalNonCollapsedMargin = m_verticalNonCollapsedMargin;
> +    box.m_margin = m_margin;
> +    box.m_border = m_border;
> +    box.m_padding = m_padding;
> +
> +#if !ASSERT_DISABLED
> +    box.m_hasValidHorizontalMargin = m_hasValidHorizontalMargin;
> +    box.m_hasValidVerticalMargin = m_hasValidVerticalMargin;
> +    box.m_hasValidVerticalNonCollapsedMargin = m_hasValidVerticalNonCollapsedMargin;
> +    box.m_hasValidBorder = m_hasValidBorder;
> +    box.m_hasValidPadding = m_hasValidPadding;
> +    box.m_hasValidContentHeight = m_hasValidContentHeight;
> +    box.m_hasValidContentWidth = m_hasValidContentWidth;
> +#endif
> +
> +    return box;
> +}

It might be nicer to add a constructor for this. If you don't want a public copy constructor you can use an enum tag. See RenderStyle for an example.

> Source/WebCore/layout/displaytree/DisplayBox.h:206
> -    const Style m_style;
> +    Style m_style;

Then you could keep this const.

[alan]

(In reply to Antti Koivisto from comment #6)
> Comment on attachment 346251 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=346251&action=review
> 
> > Source/WebCore/layout/displaytree/DisplayBox.cpp:142
> > +Box Box::clone() const
> > +{
> > +    Box box;
> > +    box.m_style = m_style;
> > +
> > +    box.m_topLeft = m_topLeft;
> > +    box.m_contentWidth = m_contentWidth;
> > +    box.m_contentHeight = m_contentHeight;
> > +    box.m_verticalNonCollapsedMargin = m_verticalNonCollapsedMargin;
> > +    box.m_margin = m_margin;
> > +    box.m_border = m_border;
> > +    box.m_padding = m_padding;
> > +
> > +#if !ASSERT_DISABLED
> > +    box.m_hasValidHorizontalMargin = m_hasValidHorizontalMargin;
> > +    box.m_hasValidVerticalMargin = m_hasValidVerticalMargin;
> > +    box.m_hasValidVerticalNonCollapsedMargin = m_hasValidVerticalNonCollapsedMargin;
> > +    box.m_hasValidBorder = m_hasValidBorder;
> > +    box.m_hasValidPadding = m_hasValidPadding;
> > +    box.m_hasValidContentHeight = m_hasValidContentHeight;
> > +    box.m_hasValidContentWidth = m_hasValidContentWidth;
> > +#endif
> > +
> > +    return box;
> > +}
> 
> It might be nicer to add a constructor for this. If you don't want a public
> copy constructor you can use an enum tag. See RenderStyle for an example.
> 
> > Source/WebCore/layout/displaytree/DisplayBox.h:206
> > -    const Style m_style;
> > +    Style m_style;
> 
> Then you could keep this const.
oh right!

[alan]

Committed r234476: <https://trac.webkit.org/changeset/234476>

[Radar WebKit Bug Importer]

<rdar://problem/42840430>