Bug 188181

Summary:

Don't call RenderTheme::platformColorsDidChange() during printing

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Printing

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, ews-watchlist, joepeck, rniwa, thorton, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews112 for mac-sierra	none
Patch	none

Timothy Hatcher

Reported 2018-07-30 14:55:54 PDT

We don't need to call RenderTheme::platformColorsDidChange() during printing anymore. RenderTheme caches dark and light mode colors separately. Also platformColorsDidChange() calls Page::updateStyleForAllPagesAfterGlobalChangeInEnvironment() which is very heavy handed and can mess up printing operations. rdar://problem/42360070

Attachments
Patch (2.37 KB, patch) 2018-07-30 15:00 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-sierra (2.31 MB, application/zip) 2018-07-30 16:05 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.87 MB, application/zip) 2018-07-30 16:13 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-sierra (3.00 MB, application/zip) 2018-07-30 16:44 PDT, EWS Watchlist	no flags	Details
Patch (2.42 KB, patch) 2018-07-30 17:35 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2018-07-30 15:00:18 PDT Comment hidden (obsolete)

Created attachment 346106 [details] Patch

EWS Watchlist

Comment 2 2018-07-30 16:05:31 PDT Comment hidden (obsolete)

Comment on attachment 346106 [details] Patch Attachment 346106 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8703917 New failing tests: inspector/page/media-query-list-listener-exception.html

EWS Watchlist

Comment 3 2018-07-30 16:05:33 PDT Comment hidden (obsolete)

Created attachment 346117 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 4 2018-07-30 16:13:34 PDT Comment hidden (obsolete)

Comment on attachment 346106 [details] Patch Attachment 346106 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8703930 New failing tests: inspector/page/media-query-list-listener-exception.html

EWS Watchlist

Comment 5 2018-07-30 16:13:36 PDT Comment hidden (obsolete)

Created attachment 346120 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 2018-07-30 16:44:25 PDT Comment hidden (obsolete)

Comment on attachment 346106 [details] Patch Attachment 346106 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8704032 New failing tests: inspector/page/media-query-list-listener-exception.html

EWS Watchlist

Comment 7 2018-07-30 16:44:26 PDT Comment hidden (obsolete)

Created attachment 346125 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6

Timothy Hatcher

Comment 8 2018-07-30 17:35:25 PDT

Created attachment 346130 [details] Patch

WebKit Commit Bot

Comment 9 2018-07-31 11:23:44 PDT

Comment on attachment 346130 [details] Patch Clearing flags on attachment: 346130 Committed r234432: <https://trac.webkit.org/changeset/234432>

WebKit Commit Bot

Comment 10 2018-07-31 11:23:46 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.