Bug 188176

Summary: [INTL] Allow "unknown" formatToParts types
Product: WebKit Reporter: Andy VanWagoner <andy>
Component: JavaScriptCoreAssignee: Andy VanWagoner <andy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews206 for win-future none

Andy VanWagoner
Reported 2018-07-30 11:27:56 PDT
[INTL] Allow "unknown" formatToParts types
Attachments
Patch (4.18 KB, patch)
2018-07-30 11:32 PDT, Andy VanWagoner 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews206 for win-future (12.96 MB, application/zip)
2018-07-30 18:23 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Andy VanWagoner
Comment 1 2018-07-30 11:32:19 PDT
Created attachment 346078 [details] Patch
Andy VanWagoner
Comment 2 2018-07-30 11:33:52 PDT
Relevant spec change: https://github.com/tc39/ecma402/pull/245 and original bug report: https://github.com/tc39/ecma402/issues/231
EWS Watchlist
Comment 3 2018-07-30 18:23:43 PDT
Comment on attachment 346078 [details] Patch Attachment 346078 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8705449 New failing tests: http/tests/security/contentSecurityPolicy/video-with-https-url-allowed-by-csp-media-src-star.html
EWS Watchlist
Comment 4 2018-07-30 18:23:55 PDT
Created attachment 346135 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Keith Miller
Comment 5 2018-08-01 13:53:12 PDT
Comment on attachment 346078 [details] Patch Test failure seems unrelated.
WebKit Commit Bot
Comment 6 2018-08-01 14:21:47 PDT
Comment on attachment 346078 [details] Patch Clearing flags on attachment: 346078 Committed r234477: <https://trac.webkit.org/changeset/234477>
WebKit Commit Bot
Comment 7 2018-08-01 14:21:48 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-08-01 20:32:40 PDT
<rdar://problem/42840445>
Note You need to log in before you can comment on or make changes to this bug.