Bug 188170

Summary:

Potential null dereference under WebPage::applicationDidBecomeActive()

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebKit2

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, ggaren, thorton, webkit-bug-importer, wenson_hsieh, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2018-07-30 09:07:01 PDT

Potential null dereference under WebPage::applicationDidBecomeActive():
Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
Exception Subtype: KERN_INVALID_ADDRESS at 0x0000000000000070
Termination Signal: Segmentation fault: 11
Termination Reason: Namespace SIGNAL, Code 0xb
Terminating Process: exc handler [0]
Triggered by Thread:  0

Thread 0 name:  Dispatch queue: com.apple.main-thread
Thread 0 Crashed:
0   WebCore                       	0x000000018b32ab6c WebCore::Page::applicationDidBecomeActive() + 44 (DumbPtrTraits.h:41)
1   WebCore                       	0x000000018b32ab58 WebCore::Page::applicationDidBecomeActive() + 24 (Function.h:83)
2   WebKit                        	0x0000000191b937fc IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) + 120 (MessageReceiverMap.cpp:0)
3   WebKit                        	0x0000000191dad534 WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 36 (WebProcess.cpp:645)
4   WebKit                        	0x0000000191b56b48 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 164 (Connection.cpp:901)
5   WebKit                        	0x0000000191b59538 IPC::Connection::dispatchOneMessage() + 232 (Connection.cpp:959)
6   JavaScriptCore                	0x0000000189849914 WTF::RunLoop::performWork() + 348 (Function.h:56)
7   JavaScriptCore                	0x0000000189849b84 WTF::RunLoop::performWork(void*) + 36 (RunLoopCF.cpp:38)
8   CoreFoundation                	0x0000000181a619e4 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 24 (CFRunLoop.c:1982)
9   CoreFoundation                	0x0000000181a612c0 __CFRunLoopDoSources0 + 456 (CFRunLoop.c:2017)
10  CoreFoundation                	0x0000000181a5ed7c __CFRunLoopRun + 1204 (CFRunLoop.c:2920)
11  CoreFoundation                	0x000000018197f488 CFRunLoopRunSpecific + 552 (CFRunLoop.c:3245)
12  Foundation                    	0x00000001823f6004 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 304 (NSRunLoop.m:367)
13  Foundation                    	0x0000000182447c6c -[NSRunLoop(NSRunLoop) run] + 88 (NSRunLoop.m:389)
14  libxpc.dylib                  	0x000000018172bbdc _xpc_objc_main + 516 (main.m:167)
15  libxpc.dylib                  	0x000000018172dcb0 xpc_main + 180 (init.c:1476)
16  com.apple.WebKit.WebContent   	0x00000001001f35ac main + 380 (XPCServiceMain.mm:148)
17  libdyld.dylib                 	0x000000018141dfc0 start + 4

Comment 1 Chris Dumez 2018-07-30 09:07:14 PDT

<rdar://problem/37493418>

Comment 2 Chris Dumez 2018-07-30 09:08:55 PDT

Created attachment 346062 [details]
Patch

Comment 3 WebKit Commit Bot 2018-07-30 09:50:48 PDT

Comment on attachment 346062 [details]
Patch

Clearing flags on attachment: 346062

Committed r234369: <https://trac.webkit.org/changeset/234369>

Comment 4 WebKit Commit Bot 2018-07-30 09:50:49 PDT

All reviewed patches have been landed.  Closing bug.