Bug 188128

Summary:

Web Inspector: Dark Mode: Search sidebar panel text field has a white background

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] Search sidebar panel text field	none
Patch	none
[Video] With patch applied	none
Patch	mattbaker: review+
Patch	none

Matt Baker

Reported 2018-07-27 15:53:58 PDT

Created attachment 345962 [details] [Image] Search sidebar panel text field Summary: Search sidebar panel text field has a white background. - After performing a global search the field is populated, but the text isn't visible against the white background.

Attachments
[Image] Search sidebar panel text field (467.79 KB, image/png) 2018-07-27 15:53 PDT, Matt Baker	no flags	Details
Patch (2.35 KB, patch) 2018-07-30 11:24 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
[Video] With patch applied (766.23 KB, video/quicktime) 2018-07-30 11:26 PDT, Nikita Vasilyev	no flags	Details
Patch (2.21 KB, patch) 2018-07-30 11:29 PDT, Nikita Vasilyev	mattbaker: review+	Details Formatted Diff Diff
Patch (2.25 KB, patch) 2018-07-30 13:13 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-07-27 15:54:26 PDT

<rdar://problem/42678270>

Nikita Vasilyev

Comment 2 2018-07-30 11:24:59 PDT

Created attachment 346074 [details] Patch

Nikita Vasilyev

Comment 3 2018-07-30 11:26:39 PDT

Created attachment 346075 [details] [Video] With patch applied

Nikita Vasilyev

Comment 4 2018-07-30 11:29:04 PDT

Created attachment 346076 [details] Patch

Matt Baker

Comment 5 2018-07-30 12:49:25 PDT

Comment on attachment 346076 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346076&action=review r=me > Source/WebInspectorUI/UserInterface/Views/DarkMode.css:919 > /* FilterBar.css */ Nit: update the comment to /* FilterBar.css, SearchBar.css */

Nikita Vasilyev

Comment 6 2018-07-30 13:13:57 PDT

Created attachment 346090 [details] Patch

WebKit Commit Bot

Comment 7 2018-07-30 16:11:03 PDT

Comment on attachment 346090 [details] Patch Clearing flags on attachment: 346090 Committed r234394: <https://trac.webkit.org/changeset/234394>

WebKit Commit Bot

Comment 8 2018-07-30 16:11:05 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.