Bug 188123

Summary:

Add some crash info to Heap::checkConn() RELEASE_ASSERTs.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, dbates, ews-watchlist, fpizlo, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	keith_miller: review+
patch for landing.	none

Mark Lam

Reported 2018-07-27 13:26:26 PDT

This is needed to help debug a crash. <rdar://problem/42672268>

Attachments
proposed patch. (20.39 KB, patch) 2018-07-27 14:04 PDT, Mark Lam	keith_miller: review+	Details Formatted Diff Diff
patch for landing. (20.53 KB, patch) 2018-07-27 14:39 PDT, Mark Lam	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2018-07-27 14:04:40 PDT

Created attachment 345951 [details] proposed patch.

EWS Watchlist

Comment 2 2018-07-27 14:07:11 PDT

Attachment 345951 [details] did not pass style-queue: ERROR: Source/WTF/wtf/Assertions.cpp:607: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Assertions.cpp:619: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Assertions.cpp:630: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Assertions.cpp:640: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Assertions.cpp:649: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Assertions.cpp:657: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Assertions.cpp:664: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Assertions.cpp:670: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Assertions.cpp:670: Extra space before ) [whitespace/parens] [2] Total errors found: 9 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Mark Lam

Comment 3 2018-07-27 14:12:57 PDT

Comment on attachment 345951 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=345951&action=review > Source/JavaScriptCore/ChangeLog:22 > + VM::isEntered() tells us is the current VM is currently executing JS code. /is/if/. Will fix before landing.

Keith Miller

Comment 4 2018-07-27 14:29:24 PDT

Comment on attachment 345951 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=345951&action=review r=me. > Source/JavaScriptCore/ChangeLog:10 > + padding space in VM and Heap, and should cost any measurable perf to initialize should *only* cost? > Source/WTF/wtf/Assertions.cpp:676 > +void WTFCrashWithInfo(int, const char*, const char*, int, uint64_t, uint64_t, uint64_t, uint64_t, uint64_t, uint64_t) { CRASH(); } I think you need another line here.

Mark Lam

Comment 5 2018-07-27 14:37:11 PDT

Comment on attachment 345951 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=345951&action=review Thanks for the review. >> Source/JavaScriptCore/ChangeLog:10 >> + padding space in VM and Heap, and should cost any measurable perf to initialize > > should *only* cost? I meant to say "should not cost" >> Source/WTF/wtf/Assertions.cpp:676 >> +void WTFCrashWithInfo(int, const char*, const char*, int, uint64_t, uint64_t, uint64_t, uint64_t, uint64_t, uint64_t) { CRASH(); } > > I think you need another line here. Fixed.

Mark Lam

Comment 6 2018-07-27 14:39:55 PDT

Created attachment 345955 [details] patch for landing.

EWS Watchlist

Comment 7 2018-07-27 14:41:56 PDT

Attachment 345955 [details] did not pass style-queue: ERROR: Source/WTF/wtf/Assertions.cpp:607: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Assertions.cpp:619: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Assertions.cpp:630: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Assertions.cpp:640: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Assertions.cpp:649: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Assertions.cpp:657: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Assertions.cpp:664: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Assertions.cpp:670: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/Assertions.cpp:670: Extra space before ) [whitespace/parens] [2] Total errors found: 9 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Mark Lam

Comment 8 2018-07-27 15:45:33 PDT

Landed in r234335: <http://trac.webkit.org/r234335>.

Mark Lam

Comment 9 2018-07-28 09:36:22 PDT

Build fix for internal build landed in r234344: <http://trac.webkit.org/r234344>.

Note You need to log in before you can comment on or make changes to this bug.