Summary: | [LayoutTests][Win] Configure perl binary location for CGI execution. | ||
---|---|---|---|
Product: | WebKit | Reporter: | Basuke Suzuki <Basuke.Suzuki> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED CONFIGURATION CHANGED | ||
Severity: | Normal | CC: | ap, Basuke.Suzuki, don.olmstead, Hironori.Fujii, lforschler, ross.kirsling |
Priority: | P2 | ||
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Basuke Suzuki
2018-07-26 01:22:50 PDT
AppleWin port is also using XAMPP Apache. I think just a mis-configuration. There is a comment. https://github.com/WebKit/webkit/blob/master/LayoutTests/http/conf/apache2.4-httpd-win.conf#L57 > # When using the above setting, specify the path to the Perl binary > # using the registry keys below: > # [HKEY_CLASSES_ROOT\.pl\Shell\ExecCGI\Command] @="c:\\PATH\TO\perl\\bin\\perl.exe" > # HKEY_CLASSES_ROOT\.cgi\Shell\ExecCGI\Command] @="c:\\PATH\TO\perl\\bin\\perl.exe" There are some perl scripts in imported directory. I think it's not feasible to convert.
> imported/blink/http/tests/misc/resources/image-slow-out-of-viewport.pl
> imported/blink/http/tests/plugins/resources/mock-plugin-with-csp.pl
> imported/blink/http/tests/security/contentSecurityPolicy/resources/frame-ancestors.pl
> imported/blink/http/tests/security/contentSecurityPolicy/resources/frame-in-frame.pl
> imported/blink/http/tests/security/contentSecurityPolicy/resources/redirect.pl
> imported/blink/http/tests/security/contentSecurityPolicy/resources/test-csp-header.pl
> imported/blink/http/tests/security/contentSecurityPolicy/resources/xhr-redirect-not-allowed.pl
> imported/blink/http/tests/xmlhttprequest/resources/invalid-utf8-json.pl
(In reply to Fujii Hironori from comment #1) > AppleWin port is also using XAMPP Apache. I think just a mis-configuration. > > There is a comment. > > https://github.com/WebKit/webkit/blob/master/LayoutTests/http/conf/apache2.4- > httpd-win.conf#L57 > > > # When using the above setting, specify the path to the Perl binary > > # using the registry keys below: > > # [HKEY_CLASSES_ROOT\.pl\Shell\ExecCGI\Command] @="c:\\PATH\TO\perl\\bin\\perl.exe" > > # HKEY_CLASSES_ROOT\.cgi\Shell\ExecCGI\Command] @="c:\\PATH\TO\perl\\bin\\perl.exe" Oh, thank you for the info. This should be documented or showing warning in some where during the launching httpd. Renamed summary from : [LayoutTests] Convert CGI written in Perl to PHP. On Windows, XAMPP is used for layout test. We can assume perl is installed in XAMPP directory. You need to install xammp-perl for WinCairo Docker. https://github.com/WebKitForWindows/powershell-webkit-dev/blob/master/WebKitDev/Functions/Install-Xampp.ps1#L34 (In reply to Fujii Hironori from comment #5) > You need to install xammp-perl for WinCairo Docker. > https://github.com/WebKitForWindows/powershell-webkit-dev/blob/master/ > WebKitDev/Functions/Install-Xampp.ps1#L34 Right. Or make it configurable by env var. Or respect the predefined registry value. Some CGI put "-T" option in the shebang line. So is the registry value. These registry must be set for bots. This was fixed in the build bot image for wincairo. |