Bug 188039 – [LayoutTests][Win] Configure perl binary location for CGI execution.

• Component: Tools / Tests
• Status: RESOLVED CONFIGURATION CHANGED

[Basuke Suzuki]

There are many CGIs used for http tests. It contains shbang line in it and usually point to /usr/bin/perl, which is not suitable for native Windows environment. PHP is more portable and I believe there's almost no case only Perl can handle some task. Let's convert'em one by one. This is the meta bug for that task.

[Fujii Hironori]

AppleWin port is also using XAMPP Apache. I think just a mis-configuration.

There is a comment.

https://github.com/WebKit/webkit/blob/master/LayoutTests/http/conf/apache2.4-httpd-win.conf#L57

> # When using the above setting, specify the path to the Perl binary
> # using the registry keys below:
> # [HKEY_CLASSES_ROOT\.pl\Shell\ExecCGI\Command] @="c:\\PATH\TO\perl\\bin\\perl.exe"
> # HKEY_CLASSES_ROOT\.cgi\Shell\ExecCGI\Command] @="c:\\PATH\TO\perl\\bin\\perl.exe"

[Fujii Hironori]

There are some perl scripts in imported directory. I think it's not feasible to convert.


> imported/blink/http/tests/misc/resources/image-slow-out-of-viewport.pl
> imported/blink/http/tests/plugins/resources/mock-plugin-with-csp.pl
> imported/blink/http/tests/security/contentSecurityPolicy/resources/frame-ancestors.pl
> imported/blink/http/tests/security/contentSecurityPolicy/resources/frame-in-frame.pl
> imported/blink/http/tests/security/contentSecurityPolicy/resources/redirect.pl
> imported/blink/http/tests/security/contentSecurityPolicy/resources/test-csp-header.pl
> imported/blink/http/tests/security/contentSecurityPolicy/resources/xhr-redirect-not-allowed.pl
> imported/blink/http/tests/xmlhttprequest/resources/invalid-utf8-json.pl

[Basuke Suzuki]

(In reply to Fujii Hironori from comment #1)
> AppleWin port is also using XAMPP Apache. I think just a mis-configuration.
> 
> There is a comment.
> 
> https://github.com/WebKit/webkit/blob/master/LayoutTests/http/conf/apache2.4-
> httpd-win.conf#L57
> 
> > # When using the above setting, specify the path to the Perl binary
> > # using the registry keys below:
> > # [HKEY_CLASSES_ROOT\.pl\Shell\ExecCGI\Command] @="c:\\PATH\TO\perl\\bin\\perl.exe"
> > # HKEY_CLASSES_ROOT\.cgi\Shell\ExecCGI\Command] @="c:\\PATH\TO\perl\\bin\\perl.exe"

Oh, thank you for the info. This should be documented or showing warning in some where during the launching httpd.

[Basuke Suzuki]

Renamed summary from : [LayoutTests] Convert CGI written in Perl to PHP.

On Windows, XAMPP is used for layout test. We can assume perl is installed in XAMPP directory.

[Fujii Hironori]

You need to install xammp-perl for WinCairo Docker.
https://github.com/WebKitForWindows/powershell-webkit-dev/blob/master/WebKitDev/Functions/Install-Xampp.ps1#L34

[Basuke Suzuki]

(In reply to Fujii Hironori from comment #5)
> You need to install xammp-perl for WinCairo Docker.
> https://github.com/WebKitForWindows/powershell-webkit-dev/blob/master/
> WebKitDev/Functions/Install-Xampp.ps1#L34

Right. Or make it configurable by env var. Or respect the predefined registry value.

[Basuke Suzuki]

Some CGI put "-T" option in the shebang line. So is the registry value.

[Basuke Suzuki]

These registry must be set for bots.

[Fujii Hironori]

https://github.com/WebKitForWindows/docker-webkit-dev/issues/7

[Don Olmstead]

This was fixed in the build bot image for wincairo.