Bug 188027

Summary: WebSiteData-related methods should take in CompletionHandlers instead of Functions
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, ews-watchlist, ggaren, sihui_liu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2018-07-25 16:11:37 PDT
WebSiteData-related methods should take in CompletionHandlers instead of Functions since they are need to be called and are only called once.
Comment 1 Chris Dumez 2018-07-25 16:25:21 PDT
Created attachment 345799 [details]
Patch
Comment 2 EWS Watchlist 2018-07-25 16:27:02 PDT
Attachment 345799 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:77:  The parameter name "completionHandler" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:105:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:115:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:146:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:165:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:98:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:99:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.h:100:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebProcessProxy.cpp:251:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebProcessProxy.h:164:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessProxy.h:81:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessProxy.h:82:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessProxy.h:83:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessProxy.h:154:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessProxy.h:161:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessProxy.h:168:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp:116:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp:129:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp:142:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 19 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2018-07-26 09:15:36 PDT
Comment on attachment 345799 [details]
Patch

Clearing flags on attachment: 345799

Committed r234261: <https://trac.webkit.org/changeset/234261>
Comment 4 WebKit Commit Bot 2018-07-26 09:15:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-07-26 09:16:24 PDT
<rdar://problem/42626196>