Summary: | Secheuristic should be proportional to width, not height. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jeremy Jones <jeremyj-wk> | ||||||||
Component: | WebKit2 | Assignee: | Jeremy Jones <jeremyj-wk> | ||||||||
Status: | NEW --- | ||||||||||
Severity: | Normal | CC: | achristensen, eric.carlson, ews-watchlist, jonlee, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | iPhone / iPad | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Jeremy Jones
2018-07-25 15:01:13 PDT
Created attachment 345791 [details]
Patch
Attachment 345791 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.cpp:68: Declaration has space between type name and * in m_widthxWeight * pow [whitespace/declaration] [3]
ERROR: Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.cpp:69: Declaration has space between type name and * in m_heightWeight * pow [whitespace/declaration] [3]
Total errors found: 2 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 345793 [details]
Patch
Attachment 345793 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.cpp:68: Declaration has space between type name and * in m_widthWeight * pow [whitespace/declaration] [3]
ERROR: Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.cpp:69: Declaration has space between type name and * in m_heightWeight * pow [whitespace/declaration] [3]
Total errors found: 2 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 345793 [details] Patch Attachment 345793 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8666569 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html Created attachment 345888 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 345793 [details]
Patch
This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.
|