Bug 188006

Summary:

[INTL] Implement hourCycle in DateTimeFormat

Product:

WebKit

Reporter:

Andy VanWagoner <andy>

Component:

JavaScriptCore

Assignee:

Andy VanWagoner <andy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
rebased	none
Archive of layout-test-results from ews205 for win-future	none
Patch	none
Archive of layout-test-results from ews205 for win-future	none

Andy VanWagoner

Reported 2018-07-25 09:20:43 PDT

[INTL] Implement hourCycle in DateTimeFormat

Attachments
Patch (30.06 KB, patch) 2018-07-25 09:29 PDT, Andy VanWagoner	no flags	Details Formatted Diff Diff
rebased (30.14 KB, patch) 2018-07-25 15:06 PDT, Andy VanWagoner	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews205 for win-future (12.90 MB, application/zip) 2018-07-27 04:34 PDT, EWS Watchlist	no flags	Details
Patch (30.09 KB, patch) 2018-07-27 08:09 PDT, Andy VanWagoner	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews205 for win-future (13.14 MB, application/zip) 2018-07-28 15:18 PDT, EWS Watchlist	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Andy VanWagoner

Comment 1 2018-07-25 09:29:26 PDT

Created attachment 345763 [details] Patch

Andy VanWagoner

Comment 2 2018-07-25 15:06:20 PDT

Created attachment 345789 [details] rebased

EWS Watchlist

Comment 3 2018-07-27 04:34:16 PDT

Comment on attachment 345789 [details] rebased Attachment 345789 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8671441 New failing tests: http/tests/security/local-video-source-from-remote.html

EWS Watchlist

Comment 4 2018-07-27 04:34:28 PDT

Created attachment 345912 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Andy VanWagoner

Comment 5 2018-07-27 08:09:54 PDT

Created attachment 345914 [details] Patch

EWS Watchlist

Comment 6 2018-07-28 15:17:47 PDT

Comment on attachment 345914 [details] Patch Attachment 345914 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8685391 New failing tests: imported/blink/transitions/unprefixed-transform.html legacy-animation-engine/imported/blink/transitions/unprefixed-transform.html

EWS Watchlist

Comment 7 2018-07-28 15:18:00 PDT

Created attachment 346002 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Keith Miller

Comment 8 2018-08-01 13:52:41 PDT

Comment on attachment 345914 [details] Patch Test failures seems unrelated.

WebKit Commit Bot

Comment 9 2018-08-01 14:19:34 PDT

Comment on attachment 345914 [details] Patch Clearing flags on attachment: 345914 Committed r234475: <https://trac.webkit.org/changeset/234475>

WebKit Commit Bot

Comment 10 2018-08-01 14:19:36 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 11 2018-08-01 20:31:36 PDT

<rdar://problem/42840429>

Note You need to log in before you can comment on or make changes to this bug.