Bug 187997

Summary: [WPE] Switch ViewBackend to using wpe_view_backend_exportable_fdo_egl APIs
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, cgarcia, clopez, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Zan Dobersek
Reported 2018-07-25 04:17:29 PDT
[WPE] Switch ViewBackend to using wpe_view_backend_exportable_fdo_egl APIs
Attachments
Patch (17.51 KB, patch)
2018-07-25 04:29 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.28 KB, patch)
2018-07-25 06:23 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-07-25 04:29:05 PDT
Created attachment 345752 [details] Patch
Carlos Garcia Campos
Comment 2 2018-07-25 04:37:39 PDT
Comment on attachment 345752 [details] Patch Thanks!
Carlos Garcia Campos
Comment 3 2018-07-25 04:38:47 PDT
I think we should fix wpe_view_backend_exportable_fdo_create() in any case, or remove it.
Adrian Perez
Comment 4 2018-07-25 04:45:19 PDT
Comment on attachment 345752 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345752&action=review Just one small nit, informal r+ otherwise. > Tools/flatpak/org.webkit.WPE.yaml:44 > + - /app/webkit/Tools/Scripts/build-webkit --wpe --prefix=/app Probably your text editor added the newline at the end of file automatically. This is unrelated to the rest of the patch.
Zan Dobersek
Comment 5 2018-07-25 06:23:30 PDT
Created attachment 345756 [details] Patch for landing
Zan Dobersek
Comment 6 2018-07-25 06:26:08 PDT
Comment on attachment 345756 [details] Patch for landing Clearing flags on attachment: 345756 Committed r234193: <https://trac.webkit.org/changeset/234193>
Zan Dobersek
Comment 7 2018-07-25 06:26:11 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-07-25 06:27:20 PDT
<rdar://problem/42580553>
Note You need to log in before you can comment on or make changes to this bug.